From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48195)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <herbszt@gmx.de>) id 1VMhUt-0002KA-32
	for qemu-devel@nongnu.org; Thu, 19 Sep 2013 12:54:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <herbszt@gmx.de>) id 1VMhUn-000172-9B
	for qemu-devel@nongnu.org; Thu, 19 Sep 2013 12:54:31 -0400
Received: from mout.gmx.net ([212.227.15.18]:53280)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <herbszt@gmx.de>) id 1VMhUm-00016t-VP
	for qemu-devel@nongnu.org; Thu, 19 Sep 2013 12:54:25 -0400
Received: from unknown ([88.74.104.224]) by mail.gmx.com (mrgmx002) with
	ESMTPSA (Nemesis) id 0Lqi70-1Vr6cu3WLK-00eIVE for
	<qemu-devel@nongnu.org>; Thu, 19 Sep 2013 18:54:23 +0200
Date: Thu, 19 Sep 2013 18:53:52 +0200
From: Sebastian Herbszt <herbszt@gmx.de>
Message-ID: <20130919185352.0000135e@unknown>
In-Reply-To: 523256B1.4020901@comstyle.com
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] Ensure PCIR is aligned to 4 bytes
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: brad@comstyle.com, qemu-devel@nongnu.org
Cc: Sebastian Herbszt <herbszt@gmx.de>

Brad Smith wrote:
> On 20/01/13 1:12 PM, David Woodhouse wrote:
>> The PCI Firmware Specification apparently requires that the PCI Data
>> Structure be DWORD-aligned. The implementation in OVMF also requires
>> this, so vgabios ROMs don't work there. With this fixed, I can now
>> initialise the VGA ROM from EFI, and EFI can display using INT 10h
>> services.
>>
>> --- vgabios-0.6c/vgabios.c.orig	2013-01-20 11:33:36.138548472
>> -0600 +++ vgabios-0.6c/vgabios.c	2013-01-20 11:36:26.060270163
>> -0600 @@ -204,6 +204,7 @@ vgabios_website:
>>   .byte	0x00
>>
>>   #ifdef PCIBIOS
>> +.align 4 // DWORD alignment required by PCI Firmware Specification
>>   vgabios_pci_data:
>>   .ascii "PCIR"
>>   #ifdef CIRRUS
> 
> We have had this in the OpenBSD port of QEMU for awhile now. Is it 
> possible to have this reviewed and commited?

This change was commited to upstream vgabios back in February [1].

[1]
http://cvs.savannah.gnu.org/viewvc/vgabios/vgabios.c?root=vgabios&view=log

Sebastian