From: Kevin Wolf <kwolf@redhat.com>
To: Jeff Cody <jcody@redhat.com>
Cc: qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH 0/5] block: use QEMU_PACKED for on-disk structures
Date: Fri, 20 Sep 2013 10:07:42 +0200 [thread overview]
Message-ID: <20130920080742.GA2800@dhcp-200-207.str.redhat.com> (raw)
In-Reply-To: <cover.1379615569.git.jcody@redhat.com>
Am 19.09.2013 um 20:43 hat Jeff Cody geschrieben:
> Several block image formats did not consistently use packed attributes
> when directly reading / writing structures from disk (mainly image format
> headers).
>
> These series updates the image formats (see list below), to use
> QEMU_PACKED for on-disk structs. (Some minor code cleanup may also
> have ensued, to keep checkpatch.pl happy)
One comment on coding style: It seems to be more common to have the
QEMU_PACKED attribute after the fields, i.e.:
struct foo {
...
} QEMU_PACKED;
Kevin
prev parent reply other threads:[~2013-09-20 8:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-19 18:43 [Qemu-devel] [PATCH 0/5] block: use QEMU_PACKED for on-disk structures Jeff Cody
2013-09-19 18:43 ` [Qemu-devel] [PATCH 1/5] block: vdi - " Jeff Cody
2013-09-19 18:43 ` [Qemu-devel] [PATCH 2/5] block: vpc " Jeff Cody
2013-09-19 18:43 ` [Qemu-devel] [PATCH 3/5] block: qcow2 - used " Jeff Cody
2013-09-19 18:43 ` [Qemu-devel] [PATCH 4/5] block: cow " Jeff Cody
2013-09-19 19:01 ` Richard Henderson
2013-09-20 4:18 ` Jeff Cody
2013-09-20 6:23 ` Markus Armbruster
2013-09-25 15:12 ` Jeff Cody
2013-09-25 17:25 ` Kevin Wolf
2013-09-25 19:01 ` Jeff Cody
2013-09-25 19:39 ` Richard Henderson
2013-09-19 18:43 ` [Qemu-devel] [PATCH 5/5] block: qed - use " Jeff Cody
2013-09-20 8:07 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130920080742.GA2800@dhcp-200-207.str.redhat.com \
--to=kwolf@redhat.com \
--cc=jcody@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).