From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55986)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1VMvkd-0001JT-AQ
	for qemu-devel@nongnu.org; Fri, 20 Sep 2013 04:07:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1VMvkY-00039L-B5
	for qemu-devel@nongnu.org; Fri, 20 Sep 2013 04:07:43 -0400
Received: from mx1.redhat.com ([209.132.183.28]:31935)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1VMvkY-00039F-3E
	for qemu-devel@nongnu.org; Fri, 20 Sep 2013 04:07:38 -0400
Received: from int-mx12.intmail.prod.int.phx2.redhat.com
	(int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r8K87bo5010197
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Fri, 20 Sep 2013 04:07:37 -0400
Date: Fri, 20 Sep 2013 10:07:42 +0200
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20130920080742.GA2800@dhcp-200-207.str.redhat.com>
References: <cover.1379615569.git.jcody@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <cover.1379615569.git.jcody@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/5] block: use QEMU_PACKED for on-disk
	structures
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jeff Cody <jcody@redhat.com>
Cc: qemu-devel@nongnu.org, stefanha@redhat.com

Am 19.09.2013 um 20:43 hat Jeff Cody geschrieben:
> Several block image formats did not consistently use packed attributes
> when directly reading / writing structures from disk (mainly image format
> headers).
> 
> These series updates the image formats (see list below), to use
> QEMU_PACKED for on-disk structs.  (Some minor code cleanup may also
> have ensued, to keep checkpatch.pl happy)

One comment on coding style: It seems to be more common to have the
QEMU_PACKED attribute after the fields, i.e.:

    struct foo {
        ...
    } QEMU_PACKED;

Kevin