From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49848)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1VN29C-0006OD-G4
	for qemu-devel@nongnu.org; Fri, 20 Sep 2013 10:57:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1VN296-0004BC-HJ
	for qemu-devel@nongnu.org; Fri, 20 Sep 2013 10:57:30 -0400
Received: from mx1.redhat.com ([209.132.183.28]:15175)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1VN296-0004B1-9N
	for qemu-devel@nongnu.org; Fri, 20 Sep 2013 10:57:24 -0400
Received: from int-mx10.intmail.prod.int.phx2.redhat.com
	(int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r8KEvNsc031019
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Fri, 20 Sep 2013 10:57:23 -0400
Date: Fri, 20 Sep 2013 16:57:28 +0200
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20130920145728.GI2800@dhcp-200-207.str.redhat.com>
References: <1379678070-14346-1-git-send-email-kwolf@redhat.com>
	<1379678070-14346-5-git-send-email-kwolf@redhat.com>
	<523C4EFE.1060705@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <523C4EFE.1060705@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 04/17] blockdev: 'blockdev-add' QMP command
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Max Reitz <mreitz@redhat.com>
Cc: qemu-devel@nongnu.org, stefanha@redhat.com, armbru@redhat.com

Am 20.09.2013 um 15:34 hat Max Reitz geschrieben:
> On 2013-09-20 13:54, Kevin Wolf wrote:
> >For examples see the changes to qmp-commands.hx.
> >
> >Signed-off-by: Kevin Wolf <kwolf@redhat.com>

> >+{ 'type': 'BlockdevThrottlingOptions',
> >+  'data': { '*bps-total': 'int',
> >+            '*bps-read': 'int',
> >+            '*bps-write': 'int',
> >+            '*iops-total': 'int',
> >+            '*iops-read': 'int',
> >+            '*iops-write': 'int' } }
> Hm, what about burst throttling?

Good catch. They were introduced only after I started this patch.

But in fact, as we discussed on Monday, I/O throttling and copy on read
should be completely removed from the interface for now so that we can
move them to a filter driver as soon as the infrastructure for them is
there.

Kevin