Re: [Qemu-devel] [PATCH V4 0/3] qemu-iotests: add test for fd passing via SCM rights

[Stefan Hajnoczi <stefanha@gmail.com>]

On Mon, Sep 09, 2013 at 01:57:20PM +0200, Stefan Hajnoczi wrote:
> On Fri, Sep 06, 2013 at 11:24:31AM +0800, Wenchao Xia wrote:
> >  tests/qemu-iotests/socket_scm_helper.c |  135 ++++++++++++++++++++++++++++++++

After a clean QEMU build ./check -raw fails now.  This can be resolved
by manually building the helper program but I think it should be part of
the main QEMU build process (make install simply won't copy the helper
program).

Wenchao: Can you send a patch to include the helper into the build
process?

045 1s ... [failed, exit status 1] - output mismatch (see 045.out.bad)
--- 045.out	2013-09-20 16:08:02.193074640 +0200
+++ 045.out.bad	2013-09-20 17:02:51.492683466 +0200
@@ -1,5 +1,49 @@
-...........
+......FF.FF
+======================================================================
+FAIL: test_add_fd (__main__.TestSCMFd)
+----------------------------------------------------------------------
+Traceback (most recent call last):
+  File "./045", line 147, in test_add_fd
+    self._send_fd_by_SCM()
+  File "./045", line 144, in _send_fd_by_SCM
+    self.assertEqual(ret, 0, 'Failed to send fd with UNIX SCM')
+AssertionError: Failed to send fd with UNIX SCM
+
+======================================================================
+FAIL: test_closefd (__main__.TestSCMFd)
+----------------------------------------------------------------------
+Traceback (most recent call last):
+  File "./045", line 164, in test_closefd
+    self._send_fd_by_SCM()
+  File "./045", line 144, in _send_fd_by_SCM
+    self.assertEqual(ret, 0, 'Failed to send fd with UNIX SCM')
+AssertionError: Failed to send fd with UNIX SCM
+
+======================================================================
+FAIL: test_getfd (__main__.TestSCMFd)
+----------------------------------------------------------------------
+Traceback (most recent call last):
+  File "./045", line 152, in test_getfd
+    self._send_fd_by_SCM()
+  File "./045", line 144, in _send_fd_by_SCM
+    self.assertEqual(ret, 0, 'Failed to send fd with UNIX SCM')
+AssertionError: Failed to send fd with UNIX SCM
+
+======================================================================
+FAIL: test_getfd_invalid_fdname (__main__.TestSCMFd)
+----------------------------------------------------------------------
+Traceback (most recent call last):
+  File "./045", line 157, in test_getfd_invalid_fdname
+    self._send_fd_by_SCM()
+  File "./045", line 144, in _send_fd_by_SCM
+    self.assertEqual(ret, 0, 'Failed to send fd with UNIX SCM')
+AssertionError: Failed to send fd with UNIX SCM
+
 ----------------------------------------------------------------------
 Ran 11 tests
 
-OK
+FAILED (failures=4)
+Scm help program does not present, path 'socket_scm_helper'.
+Scm help program does not present, path 'socket_scm_helper'.
+Scm help program does not present, path 'socket_scm_helper'.
+Scm help program does not present, path 'socket_scm_helper'.