From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54551) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VN2ND-00021t-14 for qemu-devel@nongnu.org; Fri, 20 Sep 2013 11:12:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VN2N4-0000WM-Jq for qemu-devel@nongnu.org; Fri, 20 Sep 2013 11:11:58 -0400 Received: from mail-ea0-x22f.google.com ([2a00:1450:4013:c01::22f]:59327) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VN2N4-0000WD-Dk for qemu-devel@nongnu.org; Fri, 20 Sep 2013 11:11:50 -0400 Received: by mail-ea0-f175.google.com with SMTP id m14so334399eaj.34 for ; Fri, 20 Sep 2013 08:11:49 -0700 (PDT) Date: Fri, 20 Sep 2013 17:11:47 +0200 From: Stefan Hajnoczi Message-ID: <20130920151147.GA12597@stefanha-thinkpad.redhat.com> References: <1378437874-28103-1-git-send-email-xiawenc@linux.vnet.ibm.com> <20130909115720.GB20215@stefanha-thinkpad.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130909115720.GB20215@stefanha-thinkpad.redhat.com> Subject: Re: [Qemu-devel] [PATCH V4 0/3] qemu-iotests: add test for fd passing via SCM rights List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia Cc: kwolf@redhat.com, lcapitulino@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, armbru@redhat.com On Mon, Sep 09, 2013 at 01:57:20PM +0200, Stefan Hajnoczi wrote: > On Fri, Sep 06, 2013 at 11:24:31AM +0800, Wenchao Xia wrote: > > tests/qemu-iotests/socket_scm_helper.c | 135 ++++++++++++++++++++++++++++++++ After a clean QEMU build ./check -raw fails now. This can be resolved by manually building the helper program but I think it should be part of the main QEMU build process (make install simply won't copy the helper program). Wenchao: Can you send a patch to include the helper into the build process? 045 1s ... [failed, exit status 1] - output mismatch (see 045.out.bad) --- 045.out 2013-09-20 16:08:02.193074640 +0200 +++ 045.out.bad 2013-09-20 17:02:51.492683466 +0200 @@ -1,5 +1,49 @@ -........... +......FF.FF +====================================================================== +FAIL: test_add_fd (__main__.TestSCMFd) +---------------------------------------------------------------------- +Traceback (most recent call last): + File "./045", line 147, in test_add_fd + self._send_fd_by_SCM() + File "./045", line 144, in _send_fd_by_SCM + self.assertEqual(ret, 0, 'Failed to send fd with UNIX SCM') +AssertionError: Failed to send fd with UNIX SCM + +====================================================================== +FAIL: test_closefd (__main__.TestSCMFd) +---------------------------------------------------------------------- +Traceback (most recent call last): + File "./045", line 164, in test_closefd + self._send_fd_by_SCM() + File "./045", line 144, in _send_fd_by_SCM + self.assertEqual(ret, 0, 'Failed to send fd with UNIX SCM') +AssertionError: Failed to send fd with UNIX SCM + +====================================================================== +FAIL: test_getfd (__main__.TestSCMFd) +---------------------------------------------------------------------- +Traceback (most recent call last): + File "./045", line 152, in test_getfd + self._send_fd_by_SCM() + File "./045", line 144, in _send_fd_by_SCM + self.assertEqual(ret, 0, 'Failed to send fd with UNIX SCM') +AssertionError: Failed to send fd with UNIX SCM + +====================================================================== +FAIL: test_getfd_invalid_fdname (__main__.TestSCMFd) +---------------------------------------------------------------------- +Traceback (most recent call last): + File "./045", line 157, in test_getfd_invalid_fdname + self._send_fd_by_SCM() + File "./045", line 144, in _send_fd_by_SCM + self.assertEqual(ret, 0, 'Failed to send fd with UNIX SCM') +AssertionError: Failed to send fd with UNIX SCM + ---------------------------------------------------------------------- Ran 11 tests -OK +FAILED (failures=4) +Scm help program does not present, path 'socket_scm_helper'. +Scm help program does not present, path 'socket_scm_helper'. +Scm help program does not present, path 'socket_scm_helper'. +Scm help program does not present, path 'socket_scm_helper'.