From: Stefan Hajnoczi <stefanha@gmail.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: kwolf@redhat.com, rusty@au1.ibm.com, qemu-devel@nongnu.org,
stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH 0/2] Serious bugs in the handling of writeback caching
Date: Fri, 20 Sep 2013 19:28:13 +0200 [thread overview]
Message-ID: <20130920172813.GA15239@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1379609334-20811-1-git-send-email-pbonzini@redhat.com>
On Thu, Sep 19, 2013 at 06:48:52PM +0200, Paolo Bonzini wrote:
> The first bug is simply that in 1.6.0 the default was changed by mistake
> to cache=unsafe. This affects all block drivers. It is fixed in the
> first patch.
>
> The second is that Linux guests that support the CONFIG_WCE option were
> mistaken into thinking that caching was writethrough, and thus did not
> send any flush. The bug is in QEMU, and is fixed by the second patch.
>
> Paolo Bonzini (2):
> blockdev: do not default cache.no-flush to true
> virtio-blk: do not relay a previous driver's WCE configuration to the
> current
>
> blockdev.c | 2 +-
> hw/block/virtio-blk.c | 8 ++++++--
> include/hw/virtio/virtio-blk.h | 1 +
> 3 files changed, 8 insertions(+), 3 deletions(-)
>
> --
> 1.8.3.1
>
>
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
prev parent reply other threads:[~2013-09-20 17:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-19 16:48 [Qemu-devel] [PATCH 0/2] Serious bugs in the handling of writeback caching Paolo Bonzini
2013-09-19 16:48 ` [Qemu-devel] [PATCH 1/2] blockdev: do not default cache.no-flush to true Paolo Bonzini
2013-09-19 17:33 ` Eric Blake
2013-09-19 16:48 ` [Qemu-devel] [PATCH 2/2] virtio-blk: do not relay a previous driver's WCE configuration to the current Paolo Bonzini
2013-09-19 17:42 ` Eric Blake
2013-09-20 9:54 ` Kevin Wolf
2013-09-20 10:28 ` Paolo Bonzini
2013-09-20 15:31 ` [Qemu-devel] [PATCH v2 " Paolo Bonzini
2013-09-20 17:28 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130920172813.GA15239@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rusty@au1.ibm.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).