From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56687) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VN4VC-00069i-4F for qemu-devel@nongnu.org; Fri, 20 Sep 2013 13:28:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VN4V6-0000fo-Ol for qemu-devel@nongnu.org; Fri, 20 Sep 2013 13:28:22 -0400 Received: from mail-ee0-x22e.google.com ([2a00:1450:4013:c00::22e]:48451) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VN4V6-0000fi-HZ for qemu-devel@nongnu.org; Fri, 20 Sep 2013 13:28:16 -0400 Received: by mail-ee0-f46.google.com with SMTP id c13so416270eek.33 for ; Fri, 20 Sep 2013 10:28:15 -0700 (PDT) Date: Fri, 20 Sep 2013 19:28:13 +0200 From: Stefan Hajnoczi Message-ID: <20130920172813.GA15239@stefanha-thinkpad.redhat.com> References: <1379609334-20811-1-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1379609334-20811-1-git-send-email-pbonzini@redhat.com> Subject: Re: [Qemu-devel] [PATCH 0/2] Serious bugs in the handling of writeback caching List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: kwolf@redhat.com, rusty@au1.ibm.com, qemu-devel@nongnu.org, stefanha@redhat.com On Thu, Sep 19, 2013 at 06:48:52PM +0200, Paolo Bonzini wrote: > The first bug is simply that in 1.6.0 the default was changed by mistake > to cache=unsafe. This affects all block drivers. It is fixed in the > first patch. > > The second is that Linux guests that support the CONFIG_WCE option were > mistaken into thinking that caching was writethrough, and thus did not > send any flush. The bug is in QEMU, and is fixed by the second patch. > > Paolo Bonzini (2): > blockdev: do not default cache.no-flush to true > virtio-blk: do not relay a previous driver's WCE configuration to the > current > > blockdev.c | 2 +- > hw/block/virtio-blk.c | 8 ++++++-- > include/hw/virtio/virtio-blk.h | 1 + > 3 files changed, 8 insertions(+), 3 deletions(-) > > -- > 1.8.3.1 > > Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan