From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48955) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VN8AV-0005Xy-Qc for qemu-devel@nongnu.org; Fri, 20 Sep 2013 17:23:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VN8AO-0001WU-Gv for qemu-devel@nongnu.org; Fri, 20 Sep 2013 17:23:15 -0400 Received: from mail-ie0-f179.google.com ([209.85.223.179]:61905) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VN8AO-0001WN-Cf for qemu-devel@nongnu.org; Fri, 20 Sep 2013 17:23:08 -0400 Received: by mail-ie0-f179.google.com with SMTP id e14so2089657iej.10 for ; Fri, 20 Sep 2013 14:23:07 -0700 (PDT) Date: Fri, 20 Sep 2013 22:23:08 +0100 From: Christoffer Dall Message-ID: <20130920212308.GW7623@lvm> References: <1377288624-7418-1-git-send-email-christoffer.dall@linaro.org> <1377288624-7418-6-git-send-email-christoffer.dall@linaro.org> <5229ED41.2050501@redhat.com> <20130920204116.GV7623@lvm> <523CB99B.7050700@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <523CB99B.7050700@redhat.com> Subject: Re: [Qemu-devel] [PATCH 5/5] hw: arm_gic_kvm: Add KVM VGIC save/restore logic List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, linaro-kernel@lists.linaro.org, kvmarm@lists.cs.columbia.edu, patches@linaro.org, Alexander Graf On Fri, Sep 20, 2013 at 11:09:47PM +0200, Paolo Bonzini wrote: > Il 20/09/2013 22:41, Christoffer Dall ha scritto: > >> > kvm_arm_gic_dist_readr > >> > kvm_arm_gic_dist_writer > >> > > >> > Why not get_reg/set_reg (I was quite surprised to see readr instead of > >> > reader :) and it took me a while to understand the convention)? Or if > >> > the name is too long, s/readr/get/ and s/writer/set/ would be enough to > >> > match the ioctls. > >> > > > r for register, read register, write register... > > > > I thought I'd seen this convention elsewhere, but I may be wrong. If > > you feel really strongly about it, I can rename. > > Yeah, there is readb/w/l and writeb/w/l, but I only found readreg when > grepping for readr. So I think get/set would be better. > ok, renamed to kvm_dist_[get/put] and shortened the function names in the same go, as requested by Alex. -Christoffer