From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57123) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VNfTg-0006DD-C3 for qemu-devel@nongnu.org; Sun, 22 Sep 2013 04:57:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VNfTa-0001kg-Df for qemu-devel@nongnu.org; Sun, 22 Sep 2013 04:57:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:16298) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VNfTa-0001kb-5M for qemu-devel@nongnu.org; Sun, 22 Sep 2013 04:57:10 -0400 Date: Sun, 22 Sep 2013 11:59:20 +0300 From: "Michael S. Tsirkin" Message-ID: <20130922085920.GB32658@redhat.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [RFC] sync NIC's MAC maintained in NICConf as soon as emualted NIC's MAC changed in guest List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Zhanghaoyu (A)" Cc: "chenliang (T)" , "Huangweidong (C)" , Gleb Natapov , "paolo.bonzini@gmail.com" , Jason Wang , Luonengjun , qemu-devel On Sun, Sep 22, 2013 at 08:35:29AM +0000, Zhanghaoyu (A) wrote: > Hi, all > > Do live migration if emulated NIC's MAC has been changed, RARP with wrong MAC address will broadcast via qemu_announce_self in destination, > so, long time network disconnection probably happen. Good catch. > I want to do below works to resolve this problem, > 1. change NICConf's MAC as soon as emulated NIC's MAC changed in guest This will make it impossible to revert it correctly on reset, won't it? > 2. sync NIC's (more precisely, queue) MAC to corresponding NICConf in NIC's migration load handler > > Any better ideas? > > Thanks, > Zhang Haoyu I think announce needs to poke at the current MAC instead of the default one in NICConf. We can make it respect link down state while we are at it. Happily recent linux guests aren't affected since they do announcements from guest. -- MST