qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>,
	afaerber@suse.de
Subject: Re: [Qemu-devel] [PATCH v4 22/23] hpet: add API to find it
Date: Sun, 22 Sep 2013 22:58:05 +0300	[thread overview]
Message-ID: <20130922195805.GA22116@redhat.com> (raw)
In-Reply-To: <523F4361.9040606@redhat.com>

On Sun, Sep 22, 2013 at 09:22:09PM +0200, Paolo Bonzini wrote:
> Il 22/09/2013 15:38, Michael S. Tsirkin ha scritto:
> > Add API to find HPET using QOM.
> > 
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> >  include/hw/timer/hpet.h | 2 ++
> >  hw/timer/hpet.c         | 5 +++++
> >  2 files changed, 7 insertions(+)
> > 
> > diff --git a/include/hw/timer/hpet.h b/include/hw/timer/hpet.h
> > index 757f79f..ab44bd3 100644
> > --- a/include/hw/timer/hpet.h
> > +++ b/include/hw/timer/hpet.h
> > @@ -71,4 +71,6 @@ struct hpet_fw_config
> >  } QEMU_PACKED;
> >  
> >  extern struct hpet_fw_config hpet_cfg;
> > +
> > +bool hpet_find(void);
> >  #endif
> > diff --git a/hw/timer/hpet.c b/hw/timer/hpet.c
> > index fcd22ae..676bd7d 100644
> > --- a/hw/timer/hpet.c
> > +++ b/hw/timer/hpet.c
> > @@ -757,6 +757,11 @@ static void hpet_device_class_init(ObjectClass *klass, void *data)
> >      dc->props = hpet_device_properties;
> >  }
> >  
> > +bool hpet_find(void)
> > +{
> > +    return object_resolve_path_type("", "hpet", NULL);
> 
> s/"hpet"/TYPE_HPET/
> 
> Paolo

Right. I'll fix it in my tree, won't repost just for this.
Thanks!

> > +}
> > +
> >  static const TypeInfo hpet_device_info = {
> >      .name          = TYPE_HPET,
> >      .parent        = TYPE_SYS_BUS_DEVICE,
> > 

  reply	other threads:[~2013-09-22 19:56 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-22 13:37 [Qemu-devel] [PATCH v4 00/23] qemu: generate acpi tables for the guest Michael S. Tsirkin
2013-09-22 13:37 ` [Qemu-devel] [PATCH v4 01/23] qemu: add Error to typedefs Michael S. Tsirkin
2013-09-22 13:37 ` [Qemu-devel] [PATCH v4 02/23] qom: pull in qemu/typedefs Michael S. Tsirkin
2013-09-22 13:37 ` [Qemu-devel] [PATCH v4 03/23] qom: cleanup struct Error references Michael S. Tsirkin
2013-09-22 13:37 ` [Qemu-devel] [PATCH v4 04/23] qom: add pointer to int property helpers Michael S. Tsirkin
2013-09-22 13:37 ` [Qemu-devel] [PATCH v4 05/23] fw_cfg: interface to trigger callback on read Michael S. Tsirkin
2013-09-22 13:37 ` [Qemu-devel] [PATCH v4 06/23] loader: support for unmapped ROM blobs Michael S. Tsirkin
2013-09-22 13:37 ` [Qemu-devel] [PATCH v4 07/23] pcie_host: expose UNMAPPED macro Michael S. Tsirkin
2013-09-22 13:37 ` [Qemu-devel] [PATCH v4 08/23] pcie_host: expose address format Michael S. Tsirkin
2013-09-22 13:37 ` [Qemu-devel] [PATCH v4 09/23] q35: use macro for MCFG property name Michael S. Tsirkin
2013-09-22 13:37 ` [Qemu-devel] [PATCH v4 10/23] q35: expose mmcfg size as a property Michael S. Tsirkin
2013-09-22 13:37 ` [Qemu-devel] [PATCH v4 11/23] i386: add ACPI table files from seabios Michael S. Tsirkin
2013-09-22 13:37 ` [Qemu-devel] [PATCH v4 12/23] acpi: add rules to compile ASL source Michael S. Tsirkin
2013-09-23 12:36   ` Paolo Bonzini
2013-09-23 13:39     ` Michael S. Tsirkin
2013-09-23 13:44       ` Laszlo Ersek
2013-09-22 13:37 ` [Qemu-devel] [PATCH v4 13/23] acpi: pre-compiled ASL files Michael S. Tsirkin
2013-09-22 13:37 ` [Qemu-devel] [PATCH v4 14/23] loader: use file path size from fw_cfg.h Michael S. Tsirkin
2013-09-22 13:37 ` [Qemu-devel] [PATCH v4 15/23] i386: add bios linker/loader Michael S. Tsirkin
2013-09-23 12:48   ` Paolo Bonzini
2013-09-23 13:36     ` Michael S. Tsirkin
2013-09-23 13:39       ` Paolo Bonzini
2013-09-23 13:47         ` Michael S. Tsirkin
2013-09-23 13:52           ` Paolo Bonzini
2013-09-23 19:08             ` Michael S. Tsirkin
2013-09-22 13:37 ` [Qemu-devel] [PATCH v4 16/23] loader: allow adding ROMs in done callbacks Michael S. Tsirkin
2013-09-22 13:37 ` [Qemu-devel] [PATCH v4 17/23] i386: define pc guest info Michael S. Tsirkin
2013-09-22 13:37 ` [Qemu-devel] [PATCH v4 18/23] acpi/piix: add macros for acpi property names Michael S. Tsirkin
2013-09-22 13:37 ` [Qemu-devel] [PATCH v4 19/23] piix: APIs for pc guest info Michael S. Tsirkin
2013-09-23  9:27   ` Igor Mammedov
2013-09-23 10:10     ` Michael S. Tsirkin
2013-09-23 11:14       ` Igor Mammedov
2013-09-23 11:28         ` Michael S. Tsirkin
2013-09-22 13:38 ` [Qemu-devel] [PATCH v4 20/23] ich9: " Michael S. Tsirkin
2013-09-22 13:38 ` [Qemu-devel] [PATCH v4 21/23] pvpanic: add API to access io port Michael S. Tsirkin
2013-09-22 13:38 ` [Qemu-devel] [PATCH v4 22/23] hpet: add API to find it Michael S. Tsirkin
2013-09-22 19:22   ` Paolo Bonzini
2013-09-22 19:58     ` Michael S. Tsirkin [this message]
2013-09-22 13:38 ` [Qemu-devel] [PATCH v4 23/23] i386: ACPI table generation code from seabios Michael S. Tsirkin
2013-09-24  9:23 ` [Qemu-devel] [PATCH v4 00/23] qemu: generate acpi tables for the guest Gerd Hoffmann
2013-09-24 21:45   ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130922195805.GA22116@redhat.com \
    --to=mst@redhat.com \
    --cc=afaerber@suse.de \
    --cc=anthony@codemonkey.ws \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).