From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52914)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1VNpl7-0006tY-Ac
	for qemu-devel@nongnu.org; Sun, 22 Sep 2013 15:56:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1VNpl1-0005sg-B3
	for qemu-devel@nongnu.org; Sun, 22 Sep 2013 15:55:57 -0400
Received: from mx1.redhat.com ([209.132.183.28]:25872)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1VNpl1-0005sc-39
	for qemu-devel@nongnu.org; Sun, 22 Sep 2013 15:55:51 -0400
Date: Sun, 22 Sep 2013 22:58:05 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20130922195805.GA22116@redhat.com>
References: <1379857006-17451-1-git-send-email-mst@redhat.com>
	<1379857006-17451-23-git-send-email-mst@redhat.com>
	<523F4361.9040606@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <523F4361.9040606@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v4 22/23] hpet: add API to find it
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>, afaerber@suse.de

On Sun, Sep 22, 2013 at 09:22:09PM +0200, Paolo Bonzini wrote:
> Il 22/09/2013 15:38, Michael S. Tsirkin ha scritto:
> > Add API to find HPET using QOM.
> > 
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> >  include/hw/timer/hpet.h | 2 ++
> >  hw/timer/hpet.c         | 5 +++++
> >  2 files changed, 7 insertions(+)
> > 
> > diff --git a/include/hw/timer/hpet.h b/include/hw/timer/hpet.h
> > index 757f79f..ab44bd3 100644
> > --- a/include/hw/timer/hpet.h
> > +++ b/include/hw/timer/hpet.h
> > @@ -71,4 +71,6 @@ struct hpet_fw_config
> >  } QEMU_PACKED;
> >  
> >  extern struct hpet_fw_config hpet_cfg;
> > +
> > +bool hpet_find(void);
> >  #endif
> > diff --git a/hw/timer/hpet.c b/hw/timer/hpet.c
> > index fcd22ae..676bd7d 100644
> > --- a/hw/timer/hpet.c
> > +++ b/hw/timer/hpet.c
> > @@ -757,6 +757,11 @@ static void hpet_device_class_init(ObjectClass *klass, void *data)
> >      dc->props = hpet_device_properties;
> >  }
> >  
> > +bool hpet_find(void)
> > +{
> > +    return object_resolve_path_type("", "hpet", NULL);
> 
> s/"hpet"/TYPE_HPET/
> 
> Paolo

Right. I'll fix it in my tree, won't repost just for this.
Thanks!

> > +}
> > +
> >  static const TypeInfo hpet_device_info = {
> >      .name          = TYPE_HPET,
> >      .parent        = TYPE_SYS_BUS_DEVICE,
> >