From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32973) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VO4Dt-0003LZ-US for qemu-devel@nongnu.org; Mon, 23 Sep 2013 07:22:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VO4Do-0001VE-Q3 for qemu-devel@nongnu.org; Mon, 23 Sep 2013 07:22:37 -0400 Received: from [222.73.24.84] (port=43194 helo=song.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VO4Do-0001Ue-EH for qemu-devel@nongnu.org; Mon, 23 Sep 2013 07:22:32 -0400 Date: Mon, 23 Sep 2013 19:20:41 +0800 From: Hu Tao Message-ID: <20130923112041.GC21833@localhost.localdomain> References: <089cbe1099eeb4defb5ff867eb2263eb902ed67d.1377075625.git.hutao@cn.fujitsu.com> <20130912172214.69078ed7@nial.usersys.redhat.com> MIME-Version: 1.0 In-Reply-To: <20130912172214.69078ed7@nial.usersys.redhat.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Subject: Re: [Qemu-devel] [PATCH 1/2] ich9: update sci on gpe write List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: qemu-devel@nongnu.org On Thu, Sep 12, 2013 at 05:22:14PM +0200, Igor Mammedov wrote: > On Wed, 21 Aug 2013 17:04:27 +0800 > Hu Tao wrote: > > > OSPM may disable the sci by clearing GPEx_BLK EN bit, in the case > > we have to set sci level to 0 or guest will receive sci interrupts > > endlessly. > > Could you make a more verbose comment, referring to relevant ACPI spec chapter > and it would be nice, See Section 5.6.4, ACPI 5.0, page 221. > if you experienced problem with linux guest, to add > symptoms here as well. See http://lists.gnu.org/archive/html/qemu-devel/2012-12/msg02711.html. I guess without this patch the same thing will happen in guest linux when hotplugging a vcpu. > > commit 633aa0ac did equivalent change to piix4 part, so it's worth to mention > it here. > > > Signed-off-by: Hu Tao > > --- > > hw/acpi/ich9.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/hw/acpi/ich9.c b/hw/acpi/ich9.c > > index 3fb443d..8717c15 100644 > > --- a/hw/acpi/ich9.c > > +++ b/hw/acpi/ich9.c > > @@ -79,6 +79,8 @@ static void ich9_gpe_writeb(void *opaque, hwaddr addr, uint64_t val, > > { > > ICH9LPCPMRegs *pm = opaque; > > acpi_gpe_ioport_writeb(&pm->acpi_regs, addr, val); > > + > > + pm_update_sci(pm); > > } > > > > static const MemoryRegionOps ich9_gpe_ops = {