From: Stefan Hajnoczi <stefanha@gmail.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] hmp: block-stream: fix typo
Date: Mon, 23 Sep 2013 14:10:30 +0200 [thread overview]
Message-ID: <20130923121030.GA3623@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1379682463-5496-1-git-send-email-anthony@codemonkey.ws>
On Fri, Sep 20, 2013 at 08:07:43AM -0500, Anthony Liguori wrote:
> Found this by enabling C++ errors. The bool and enum arguments
> are mistakenly flipped.
>
> Signed-off-by: Anthony Liguori <anthony@codemonkey.ws>
> ---
> hmp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hmp.c b/hmp.c
> index 2a90295..5891507 100644
> --- a/hmp.c
> +++ b/hmp.c
> @@ -1163,7 +1163,7 @@ void hmp_block_stream(Monitor *mon, const QDict *qdict)
>
> qmp_block_stream(device, base != NULL, base,
> qdict_haskey(qdict, "speed"), speed,
> - BLOCKDEV_ON_ERROR_REPORT, true, &error);
> + true, BLOCKDEV_ON_ERROR_REPORT, &error);
>
> hmp_handle_error(mon, &error);
> }
> --
> 1.8.0
Acked-by: Stefan Hajnoczi <stefanha@redhat.com>
prev parent reply other threads:[~2013-09-23 12:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-20 13:07 [Qemu-devel] [PATCH] hmp: block-stream: fix typo Anthony Liguori
2013-09-23 12:10 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130923121030.GA3623@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=anthony@codemonkey.ws \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).