From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41848) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VO4yQ-0000j5-Fj for qemu-devel@nongnu.org; Mon, 23 Sep 2013 08:10:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VO4yJ-00077V-6Q for qemu-devel@nongnu.org; Mon, 23 Sep 2013 08:10:42 -0400 Received: from mail-ea0-x22f.google.com ([2a00:1450:4013:c01::22f]:49439) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VO4yI-000779-VX for qemu-devel@nongnu.org; Mon, 23 Sep 2013 08:10:35 -0400 Received: by mail-ea0-f175.google.com with SMTP id m14so1684950eaj.34 for ; Mon, 23 Sep 2013 05:10:34 -0700 (PDT) Date: Mon, 23 Sep 2013 14:10:30 +0200 From: Stefan Hajnoczi Message-ID: <20130923121030.GA3623@stefanha-thinkpad.redhat.com> References: <1379682463-5496-1-git-send-email-anthony@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1379682463-5496-1-git-send-email-anthony@codemonkey.ws> Subject: Re: [Qemu-devel] [PATCH] hmp: block-stream: fix typo List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Kevin Wolf , qemu-devel@nongnu.org On Fri, Sep 20, 2013 at 08:07:43AM -0500, Anthony Liguori wrote: > Found this by enabling C++ errors. The bool and enum arguments > are mistakenly flipped. > > Signed-off-by: Anthony Liguori > --- > hmp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hmp.c b/hmp.c > index 2a90295..5891507 100644 > --- a/hmp.c > +++ b/hmp.c > @@ -1163,7 +1163,7 @@ void hmp_block_stream(Monitor *mon, const QDict *qdict) > > qmp_block_stream(device, base != NULL, base, > qdict_haskey(qdict, "speed"), speed, > - BLOCKDEV_ON_ERROR_REPORT, true, &error); > + true, BLOCKDEV_ON_ERROR_REPORT, &error); > > hmp_handle_error(mon, &error); > } > -- > 1.8.0 Acked-by: Stefan Hajnoczi