From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49348) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VO5W6-0005hr-0S for qemu-devel@nongnu.org; Mon, 23 Sep 2013 08:45:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VO5Vt-0000Yr-PH for qemu-devel@nongnu.org; Mon, 23 Sep 2013 08:45:29 -0400 Received: from mail-ea0-x232.google.com ([2a00:1450:4013:c01::232]:50048) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VO5Vt-0000Yc-Hf for qemu-devel@nongnu.org; Mon, 23 Sep 2013 08:45:17 -0400 Received: by mail-ea0-f178.google.com with SMTP id a15so1718487eae.9 for ; Mon, 23 Sep 2013 05:45:16 -0700 (PDT) Date: Mon, 23 Sep 2013 14:45:13 +0200 From: Stefan Hajnoczi Message-ID: <20130923124513.GC3623@stefanha-thinkpad.redhat.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH v2 3/3] block: qemu-iotests - quote $TEST_IMG* and $TEST_DIR usage List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jeff Cody Cc: kwolf@redhat.com, famz@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com On Fri, Sep 20, 2013 at 01:12:40PM -0400, Jeff Cody wrote: > diff --git a/tests/qemu-iotests/043 b/tests/qemu-iotests/043 > index 478773d..ae7cf27 100755 > --- a/tests/qemu-iotests/043 > +++ b/tests/qemu-iotests/043 > @@ -31,7 +31,7 @@ status=1 # failure is the default! > _cleanup() > { > _cleanup_test_img > - rm -f $TEST_IMG.[123].base > + rm -f "$TEST_IMG.[123].base" This changes the semantics: $ touch a1 a2 a3 $ echo a[123] a1 a2 a3 $ echo "a[123]" a[123]