From: Stefan Hajnoczi <stefanha@gmail.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] scsi: prefer UUID to VM name for the initiator name
Date: Mon, 23 Sep 2013 15:32:08 +0200 [thread overview]
Message-ID: <20130923133208.GD5814@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <523180A4.4080700@redhat.com>
On Thu, Sep 12, 2013 at 10:51:48AM +0200, Paolo Bonzini wrote:
> Il 12/09/2013 10:38, Stefan Hajnoczi ha scritto:
> > On Tue, Sep 10, 2013 at 06:40:04PM +0200, Paolo Bonzini wrote:
> >> The UUID is unique even across multiple hosts, thus it is
> >> better than a VM name even if it is less user-friendly.
> >>
> >> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> >> ---
> >> block/iscsi.c | 23 ++++++++++++++++-------
> >> include/sysemu/sysemu.h | 2 ++
> >> stubs/Makefile.objs | 1 +
> >> stubs/uuid.c | 12 ++++++++++++
> >> 4 files changed, 31 insertions(+), 7 deletions(-)
> >> create mode 100644 stubs/uuid.c
> >
> > Will changing the initiator name break existing setups/ACLs?
>
> The username for authentication is separate from the initiator name.
>
> It could break persistent reservations, but there is a workaround
> (specify the initiator name manually through "-iscsi"). I'll make sure
> to document this in the release changelog.
>
> Does it look good?
It's already merged but for the record, I'm happy with the patch.
Stefan
prev parent reply other threads:[~2013-09-23 13:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-10 16:40 [Qemu-devel] [PATCH] scsi: prefer UUID to VM name for the initiator name Paolo Bonzini
2013-09-12 8:38 ` Stefan Hajnoczi
2013-09-12 8:51 ` Paolo Bonzini
2013-09-23 13:32 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130923133208.GD5814@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).