From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57857) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VO6Fm-00014n-AC for qemu-devel@nongnu.org; Mon, 23 Sep 2013 09:32:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VO6Fb-0005KO-KY for qemu-devel@nongnu.org; Mon, 23 Sep 2013 09:32:42 -0400 Received: from mail-ee0-x229.google.com ([2a00:1450:4013:c00::229]:64704) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VO6Fb-0005KE-DN for qemu-devel@nongnu.org; Mon, 23 Sep 2013 09:32:31 -0400 Received: by mail-ee0-f41.google.com with SMTP id d17so1746739eek.14 for ; Mon, 23 Sep 2013 06:32:29 -0700 (PDT) Date: Mon, 23 Sep 2013 15:32:08 +0200 From: Stefan Hajnoczi Message-ID: <20130923133208.GD5814@stefanha-thinkpad.redhat.com> References: <1378831204-25256-1-git-send-email-pbonzini@redhat.com> <20130912083808.GF1965@stefanha-thinkpad.redhat.com> <523180A4.4080700@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <523180A4.4080700@redhat.com> Subject: Re: [Qemu-devel] [PATCH] scsi: prefer UUID to VM name for the initiator name List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org On Thu, Sep 12, 2013 at 10:51:48AM +0200, Paolo Bonzini wrote: > Il 12/09/2013 10:38, Stefan Hajnoczi ha scritto: > > On Tue, Sep 10, 2013 at 06:40:04PM +0200, Paolo Bonzini wrote: > >> The UUID is unique even across multiple hosts, thus it is > >> better than a VM name even if it is less user-friendly. > >> > >> Signed-off-by: Paolo Bonzini > >> --- > >> block/iscsi.c | 23 ++++++++++++++++------- > >> include/sysemu/sysemu.h | 2 ++ > >> stubs/Makefile.objs | 1 + > >> stubs/uuid.c | 12 ++++++++++++ > >> 4 files changed, 31 insertions(+), 7 deletions(-) > >> create mode 100644 stubs/uuid.c > > > > Will changing the initiator name break existing setups/ACLs? > > The username for authentication is separate from the initiator name. > > It could break persistent reservations, but there is a workaround > (specify the initiator name manually through "-iscsi"). I'll make sure > to document this in the release changelog. > > Does it look good? It's already merged but for the record, I'm happy with the patch. Stefan