From: Riku Voipio <riku.voipio@iki.fi>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Stefan Weil <sw@weilnetz.de>, qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] linux-user: Fix wrong use of stat instead of stat64 for sparc64
Date: Tue, 24 Sep 2013 12:13:58 +0300 [thread overview]
Message-ID: <20130924091358.GA25243@afflict.kos.to> (raw)
In-Reply-To: <CAFEAcA_miGdE46iBK0h0DbnWEU=sswjR7tE6iF7Jjb7QUHBZKg@mail.gmail.com>
On Mon, Sep 23, 2013 at 09:05:03PM +0900, Peter Maydell wrote:
> On 23 September 2013 20:57, Riku Voipio <riku.voipio@iki.fi> wrote:
> > On Thu, Sep 19, 2013 at 07:31:51PM +0200, Stefan Weil wrote:
> >> Ping? Are there any more opinions how qemu-sparc64 should be fixed?
> >> Should we choose Peter's approach (which is good, but with a
> >> higher risk than my patch)?
> >
> > I've included it now in my qeu, since it fixes qemu-sparc64 in my
> > smoketest and causes seemingly no regressions on other platforms.
> Yeah, but I bet there are other platforms we're not getting this
> right on since the #ifdef here isn't the same as the #ifdef that
> decides whether we have a target_stat64 struct or not...
Ok, I'll leave the patch on table then, and send this pullrequest
without it. Stefan, can you base the fix on setting
TARGET_NO_STRUCT_STAT64 when it is not available?
Riku
prev parent reply other threads:[~2013-09-24 9:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-06 16:46 [Qemu-devel] [PATCH] linux-user: Fix wrong use of stat instead of stat64 for sparc64 Stefan Weil
2013-09-06 17:16 ` Peter Maydell
2013-09-06 17:24 ` Stefan Weil
2013-09-19 17:31 ` Stefan Weil
2013-09-23 11:57 ` Riku Voipio
2013-09-23 12:05 ` Peter Maydell
2013-09-24 9:13 ` Riku Voipio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130924091358.GA25243@afflict.kos.to \
--to=riku.voipio@iki.fi \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).