From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45911)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <nchip@afflict.kos.to>) id 1VOOh2-0003kj-N4
	for qemu-devel@nongnu.org; Tue, 24 Sep 2013 05:14:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <nchip@afflict.kos.to>) id 1VOOgy-0003lH-20
	for qemu-devel@nongnu.org; Tue, 24 Sep 2013 05:14:04 -0400
Received: from afflict.kos.to ([92.243.29.197]:49225)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <nchip@afflict.kos.to>) id 1VOOgx-0003l9-Rw
	for qemu-devel@nongnu.org; Tue, 24 Sep 2013 05:13:59 -0400
Date: Tue, 24 Sep 2013 12:13:58 +0300
From: Riku Voipio <riku.voipio@iki.fi>
Message-ID: <20130924091358.GA25243@afflict.kos.to>
References: <1378485978-32108-1-git-send-email-sw@weilnetz.de>
	<CAFEAcA9m8ovnge2haczukBBphE+SkUxhfFxdrOqFqgQ1M4OOHw@mail.gmail.com>
	<522A0FC9.6090205@weilnetz.de> <523B3507.8040301@weilnetz.de>
	<20130923115717.GA14290@afflict.kos.to>
	<CAFEAcA_miGdE46iBK0h0DbnWEU=sswjR7tE6iF7Jjb7QUHBZKg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAFEAcA_miGdE46iBK0h0DbnWEU=sswjR7tE6iF7Jjb7QUHBZKg@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH] linux-user: Fix wrong use of stat instead
 of stat64 for sparc64
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Stefan Weil <sw@weilnetz.de>, qemu-devel <qemu-devel@nongnu.org>

On Mon, Sep 23, 2013 at 09:05:03PM +0900, Peter Maydell wrote:
> On 23 September 2013 20:57, Riku Voipio <riku.voipio@iki.fi> wrote:
> > On Thu, Sep 19, 2013 at 07:31:51PM +0200, Stefan Weil wrote:
> >> Ping? Are there any more opinions how qemu-sparc64 should be fixed?
> >> Should we choose Peter's approach (which is good, but with a
> >> higher risk than my patch)?
> >
> > I've included it now in my qeu, since it fixes qemu-sparc64 in my
> > smoketest and causes seemingly no regressions on other platforms.
 
> Yeah, but I bet there are other platforms we're not getting this
> right on since the #ifdef here isn't the same as the #ifdef that
> decides whether we have a target_stat64 struct or not...

Ok, I'll leave the patch on table then, and send this pullrequest
without it. Stefan, can you base the fix on setting 
TARGET_NO_STRUCT_STAT64 when it is not available?

Riku