From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45132) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VOQWP-0005De-ME for qemu-devel@nongnu.org; Tue, 24 Sep 2013 07:11:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VOQWJ-0001PZ-NM for qemu-devel@nongnu.org; Tue, 24 Sep 2013 07:11:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:23665) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VOQWJ-0001Or-Fv for qemu-devel@nongnu.org; Tue, 24 Sep 2013 07:11:07 -0400 Date: Tue, 24 Sep 2013 13:10:59 +0200 From: Kevin Wolf Message-ID: <20130924111059.GB3011@dhcp-200-207.str.redhat.com> References: <1379678070-14346-1-git-send-email-kwolf@redhat.com> <1379678070-14346-5-git-send-email-kwolf@redhat.com> <20130920140109.GB6794@irqsave.net> <52416C56.5070809@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <52416C56.5070809@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 04/17] blockdev: 'blockdev-add' QMP command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: =?iso-8859-1?Q?Beno=EEt?= Canet , armbru@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, mreitz@redhat.com Am 24.09.2013 um 12:41 hat Paolo Bonzini geschrieben: > Il 20/09/2013 16:01, Beno=EEt Canet ha scritto: > >> > + if (error_is_set(&local_err)) { > >> > + error_propagate(errp, local_err); > >> > + goto fail; > > There is nothing to execute between error_propagate and fail: maybe w= e could > > get rid of the goto. >=20 > Or perhaps of the "else". Indeed, that looks a bit strange now... It doesn't survive until the end of the series anyway, but I can remove it here. (The else branch has a useless goto as well, but I'd prefer to leave it there in case new code is added later - it's easy to miss when a goto becomes necessary.) Kevin