From: Kevin Wolf <kwolf@redhat.com>
To: Max Reitz <mreitz@redhat.com>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] qcow2: Don't shadow return value
Date: Tue, 24 Sep 2013 16:59:45 +0200 [thread overview]
Message-ID: <20130924145945.GD3011@dhcp-200-207.str.redhat.com> (raw)
In-Reply-To: <1380023446-18176-1-git-send-email-mreitz@redhat.com>
Am 24.09.2013 um 13:50 hat Max Reitz geschrieben:
> When trying to update the refcounts for a snapshot, the return value of
> update_refcount on a compressed cluster was pretty much ignored,
> cancelling the update on error but returning 0. This is caused by an
> inner "ret" variable shadowing the outer one (the latter is used in the
> return statement).
>
> Signed-off-by: Max Reitz <mreitz@redhat.com>
Thanks, applied to the block branch.
Kevin
prev parent reply other threads:[~2013-09-24 15:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-24 11:50 [Qemu-devel] [PATCH] qcow2: Don't shadow return value Max Reitz
2013-09-24 14:59 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130924145945.GD3011@dhcp-200-207.str.redhat.com \
--to=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).