From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45873) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VOU5s-0000NL-Us for qemu-devel@nongnu.org; Tue, 24 Sep 2013 11:00:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VOU5m-0006eD-Tp for qemu-devel@nongnu.org; Tue, 24 Sep 2013 11:00:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44810) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VOU5m-0006e8-Kk for qemu-devel@nongnu.org; Tue, 24 Sep 2013 10:59:58 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r8OExvRo012224 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 24 Sep 2013 10:59:58 -0400 Date: Tue, 24 Sep 2013 16:59:45 +0200 From: Kevin Wolf Message-ID: <20130924145945.GD3011@dhcp-200-207.str.redhat.com> References: <1380023446-18176-1-git-send-email-mreitz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1380023446-18176-1-git-send-email-mreitz@redhat.com> Subject: Re: [Qemu-devel] [PATCH] qcow2: Don't shadow return value List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: qemu-devel@nongnu.org, Stefan Hajnoczi Am 24.09.2013 um 13:50 hat Max Reitz geschrieben: > When trying to update the refcounts for a snapshot, the return value of > update_refcount on a compressed cluster was pretty much ignored, > cancelling the update on error but returning 0. This is caused by an > inner "ret" variable shadowing the outer one (the latter is used in the > return statement). > > Signed-off-by: Max Reitz Thanks, applied to the block branch. Kevin