From: Jeff Cody <jcody@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: kwolf@redhat.com, famz@redhat.com, qemu-devel@nongnu.org,
stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 3/3] block: qemu-iotests - quote $TEST_IMG* and $TEST_DIR usage
Date: Tue, 24 Sep 2013 17:03:03 -0400 [thread overview]
Message-ID: <20130924210303.GB5035@localhost.localdomain> (raw)
In-Reply-To: <20130923124513.GC3623@stefanha-thinkpad.redhat.com>
On Mon, Sep 23, 2013 at 02:45:13PM +0200, Stefan Hajnoczi wrote:
> On Fri, Sep 20, 2013 at 01:12:40PM -0400, Jeff Cody wrote:
> > diff --git a/tests/qemu-iotests/043 b/tests/qemu-iotests/043
> > index 478773d..ae7cf27 100755
> > --- a/tests/qemu-iotests/043
> > +++ b/tests/qemu-iotests/043
> > @@ -31,7 +31,7 @@ status=1 # failure is the default!
> > _cleanup()
> > {
> > _cleanup_test_img
> > - rm -f $TEST_IMG.[123].base
> > + rm -f "$TEST_IMG.[123].base"
>
> This changes the semantics:
>
> $ touch a1 a2 a3
> $ echo a[123]
> a1 a2 a3
> $ echo "a[123]"
> a[123]
Yes, that should be "$TEST_IMG".[123].base instead.
next prev parent reply other threads:[~2013-09-24 21:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-20 17:12 [Qemu-devel] [PATCH v2 0/3] qemu-iotests with sample images, vhdx test, cleanup Jeff Cody
2013-09-20 17:12 ` [Qemu-devel] [PATCH v2 1/3] block: qemu-iotests - add basic ability to use binary sample images Jeff Cody
2013-09-20 17:12 ` [Qemu-devel] [PATCH v2 2/3] block: qemu-iotests for vhdx, read sample dynamic image Jeff Cody
2013-09-20 17:12 ` [Qemu-devel] [PATCH v2 3/3] block: qemu-iotests - quote $TEST_IMG* and $TEST_DIR usage Jeff Cody
2013-09-23 12:45 ` Stefan Hajnoczi
2013-09-24 21:03 ` Jeff Cody [this message]
2013-09-25 8:12 ` [Qemu-devel] [PATCH v2 0/3] qemu-iotests with sample images, vhdx test, cleanup Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130924210303.GB5035@localhost.localdomain \
--to=jcody@redhat.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).