From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38311)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jcody@redhat.com>) id 1VOZlK-0006zi-7D
	for qemu-devel@nongnu.org; Tue, 24 Sep 2013 17:03:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jcody@redhat.com>) id 1VOZlE-0000am-9r
	for qemu-devel@nongnu.org; Tue, 24 Sep 2013 17:03:14 -0400
Received: from mx1.redhat.com ([209.132.183.28]:34003)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jcody@redhat.com>) id 1VOZlE-0000Zy-1r
	for qemu-devel@nongnu.org; Tue, 24 Sep 2013 17:03:08 -0400
Date: Tue, 24 Sep 2013 17:03:03 -0400
From: Jeff Cody <jcody@redhat.com>
Message-ID: <20130924210303.GB5035@localhost.localdomain>
References: <cover.1379695558.git.jcody@redhat.com>
	<ed6d7e14259298abb4dba38ab6baa90344e9ceb6.1379695558.git.jcody@redhat.com>
	<20130923124513.GC3623@stefanha-thinkpad.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20130923124513.GC3623@stefanha-thinkpad.redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 3/3] block: qemu-iotests - quote
 $TEST_IMG* and $TEST_DIR usage
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: kwolf@redhat.com, famz@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com

On Mon, Sep 23, 2013 at 02:45:13PM +0200, Stefan Hajnoczi wrote:
> On Fri, Sep 20, 2013 at 01:12:40PM -0400, Jeff Cody wrote:
> > diff --git a/tests/qemu-iotests/043 b/tests/qemu-iotests/043
> > index 478773d..ae7cf27 100755
> > --- a/tests/qemu-iotests/043
> > +++ b/tests/qemu-iotests/043
> > @@ -31,7 +31,7 @@ status=1	# failure is the default!
> >  _cleanup()
> >  {
> >      _cleanup_test_img
> > -    rm -f $TEST_IMG.[123].base
> > +    rm -f "$TEST_IMG.[123].base"
> 
> This changes the semantics:
> 
>   $ touch a1 a2 a3
>   $ echo a[123]
>   a1 a2 a3
>   $ echo "a[123]"
>   a[123]

Yes, that should be "$TEST_IMG".[123].base instead.