From: Michael Roth <mdroth@linux.vnet.ibm.com>
To: Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Anthony Liguori <aliguori@us.ibm.com>,
qemu-stable@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-stable] [PATCH for-1.6] qemu-timer: fix get_clock() gettimeofday() fallback #ifdef
Date: Tue, 24 Sep 2013 16:59:46 -0500 [thread overview]
Message-ID: <20130924215946.25429.75793@loki> (raw)
In-Reply-To: <20130924215822.25429.16708@loki>
Quoting Michael Roth (2013-09-24 16:58:22)
> Quoting Stefan Hajnoczi (2013-08-06 06:48:58)
> > If CLOCK_MONOTONIC is not defined by system headers we use
> > gettimeofday(2). Apparently this is not used very often since no one
> > noticed the #ifdef was actually broken and left the function definition
> > unterminated.
> >
> > Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
>
> Ping, looking to pull this in for stable.
Bah, ignore this. Didn't see previous discussion.
>
> > ---
> > include/qemu/timer.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/qemu/timer.h b/include/qemu/timer.h
> > index 9dd206c..e3299b8 100644
> > --- a/include/qemu/timer.h
> > +++ b/include/qemu/timer.h
> > @@ -125,8 +125,8 @@ static inline int64_t get_clock(void)
> > changes, so it should be avoided. */
> > return get_clock_realtime();
> > }
> > -}
> > #endif
> > +}
> >
> > void qemu_get_timer(QEMUFile *f, QEMUTimer *ts);
> > void qemu_put_timer(QEMUFile *f, QEMUTimer *ts);
> > --
> > 1.8.1.4
prev parent reply other threads:[~2013-09-24 22:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-06 11:48 [Qemu-devel] [PATCH for-1.6] qemu-timer: fix get_clock() gettimeofday() fallback #ifdef Stefan Hajnoczi
2013-08-07 0:26 ` Brad Smith
2013-08-07 7:53 ` Stefan Hajnoczi
2013-09-24 21:58 ` [Qemu-devel] [Qemu-stable] " Michael Roth
2013-09-24 21:59 ` Michael Roth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130924215946.25429.75793@loki \
--to=mdroth@linux.vnet.ibm.com \
--cc=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).