qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Michael Roth <mdroth@linux.vnet.ibm.com>
To: Amit Shah <amit.shah@redhat.com>, qemu list <qemu-devel@nongnu.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Gerd Hoffmann <kraxel@redhat.com>,
	Anthony Liguori <anthony@codemonkey.ws>,
	Hans de Goede <hdegoede@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 0/3] char: fix segfault on chardev detach
Date: Tue, 24 Sep 2013 19:50:23 -0500	[thread overview]
Message-ID: <20130925005023.25429.77400@loki> (raw)
In-Reply-To: <cover.1377693391.git.amit.shah@redhat.com>

Quoting Amit Shah (2013-08-28 07:37:19)
> This series fixes a segfault when a frontend is detached from a
> chardev while the chardev had a pending callback registered.  Further
> details in patch 3.
> 
> Please review.

Reviewed-by: Michael Roth <mdroth@linux.vnet.ibm.com>

Ping for 1.6.1

> 
> v3:
>  * fix whitespace issues in patch 1
> v2:
>  * Move tag property to CharDriverState to simplify everything (Gerd)
> 
> Amit Shah (3):
>   char: move backends' io watch tag to CharDriverState
>   char: use common function to disable callbacks on chardev close
>   char: remove watch callback on chardev detach from frontend
> 
>  include/sysemu/char.h |  1 +
>  qemu-char.c           | 82 +++++++++++++++++++--------------------------------
>  2 files changed, 32 insertions(+), 51 deletions(-)
> 
> -- 
> 1.8.3.1

      parent reply	other threads:[~2013-09-25  0:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-28 12:37 [Qemu-devel] [PATCH v3 0/3] char: fix segfault on chardev detach Amit Shah
2013-08-28 12:37 ` [Qemu-devel] [PATCH v3 1/3] char: move backends' io watch tag to CharDriverState Amit Shah
2013-08-28 12:37 ` [Qemu-devel] [PATCH v3 2/3] char: use common function to disable callbacks on chardev close Amit Shah
2013-08-28 12:37 ` [Qemu-devel] [PATCH v3 3/3] char: remove watch callback on chardev detach from frontend Amit Shah
2013-09-25  0:50 ` Michael Roth [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130925005023.25429.77400@loki \
    --to=mdroth@linux.vnet.ibm.com \
    --cc=amit.shah@redhat.com \
    --cc=anthony@codemonkey.ws \
    --cc=hdegoede@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).