From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51056)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1VOjLp-0007OU-NQ
	for qemu-devel@nongnu.org; Wed, 25 Sep 2013 03:17:39 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1VOjLj-0002oX-K3
	for qemu-devel@nongnu.org; Wed, 25 Sep 2013 03:17:33 -0400
Received: from mx1.redhat.com ([209.132.183.28]:59995)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1VOjLj-0002oN-C8
	for qemu-devel@nongnu.org; Wed, 25 Sep 2013 03:17:27 -0400
Date: Wed, 25 Sep 2013 09:17:23 +0200
From: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20130925071723.GA25889@stefanha-thinkpad.redhat.com>
References: <1379990464-2721-1-git-send-email-famz@redhat.com>
	<1379990974-3348-1-git-send-email-famz@redhat.com>
	<20130924124945.GB12579@stefanha-thinkpad.redhat.com>
	<20130925005810.GA11134@T430s.nay.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20130925005810.GA11134@T430s.nay.redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/2] qemu-iotests: fix test case 059
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: kwolf@redhat.com, Stefan Hajnoczi <stefanha@gmail.com>, qemu-devel@nongnu.org

On Wed, Sep 25, 2013 at 08:58:10AM +0800, Fam Zheng wrote:
> On Tue, 09/24 14:49, Stefan Hajnoczi wrote:
> > On Tue, Sep 24, 2013 at 10:49:33AM +0800, Fam Zheng wrote:
> > > Since commit "block: Error parameter for open functions", error output
> > > is more verbose. Update test case output file to follow the change.
> > 
> > This doesn't explain the "Formatting ..." trailing space change.
> > 
> > If this has changed, please split the change into a separate patch, with
> > an explanation of when the space was introduced, and fix the other test
> > case output files:
> > 
> > $ git grep '^Formatting' | grep '[^ ]$'
> > 017.out:Formatting 'TEST_DIR/t.IMGFMT.base', fmt=IMGFMT size=6442450944
> > 018.out:Formatting 'TEST_DIR/t.IMGFMT.base', fmt=IMGFMT size=6442450944
> > 048.out:Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=1073741824
> > 059.out:Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=67108864
> > 059.out:Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=67108864
> > 059.out:Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=67108864
> > 063.out:Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=4194304
> > 063.out:Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=2097152
> 
> Not sure how it's introduced, it is actually ignored when comparing because we
> have "-w" for diff command. I'll drop the spaces here and send another
> revision, I'd like focus this series for fixing vmdk and leave the space clean
> up for another series (if necessary).

Good idea.  Given the diff -w option I don't see a need to change the
whitespace.

Stefan