From: Kevin Wolf <kwolf@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: "Benoît Canet" <benoit@irqsave.net>,
stefanha@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH V4] block: introduce BlockDriver.bdrv_needs_filename to enable some drivers.
Date: Wed, 25 Sep 2013 13:25:39 +0200 [thread overview]
Message-ID: <20130925112539.GD2898@dhcp-200-207.str.redhat.com> (raw)
In-Reply-To: <5241AE08.1030400@redhat.com>
Am 24.09.2013 um 17:21 hat Eric Blake geschrieben:
> On 09/24/2013 09:07 AM, Benoît Canet wrote:
> > Some drivers will have driver specifics options but no filename.
> > This new bool allow the block layer to treat them correctly.
> >
> > The .bdrv_needs_filename is set in drivers not having .bdrv_parse_filename and
> > not having .bdrv_open.
> >
> > The first exception to this rule will be the quorum driver.
> >
> > Signed-off-by: Benoit Canet <benoit@irqsave.net>
> > ---
> > block.c | 5 +++--
> > block/gluster.c | 4 ++++
> > block/iscsi.c | 1 +
> > block/raw-posix.c | 5 +++++
> > block/raw-win32.c | 2 ++
> > block/rbd.c | 1 +
> > block/sheepdog.c | 3 +++
> > include/block/block_int.h | 6 ++++++
> > 8 files changed, 25 insertions(+), 2 deletions(-)
>
> Reviewed-by: Eric Blake <eblake@redhat.com>
Thanks, applied to the block branch (with manual conflict resolution)
Kevin
prev parent reply other threads:[~2013-09-25 11:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-24 15:07 [Qemu-devel] [PATCH V4] introduce .bdrv_needs_filename Benoît Canet
2013-09-24 15:07 ` [Qemu-devel] [PATCH V4] block: introduce BlockDriver.bdrv_needs_filename to enable some drivers Benoît Canet
2013-09-24 15:21 ` Eric Blake
2013-09-25 11:25 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130925112539.GD2898@dhcp-200-207.str.redhat.com \
--to=kwolf@redhat.com \
--cc=benoit@irqsave.net \
--cc=eblake@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).