From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52779)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1VOnE9-00042Q-DY
	for qemu-devel@nongnu.org; Wed, 25 Sep 2013 07:25:58 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1VOnE4-0003NO-3z
	for qemu-devel@nongnu.org; Wed, 25 Sep 2013 07:25:53 -0400
Received: from mx1.redhat.com ([209.132.183.28]:60236)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1VOnE3-0003NH-SH
	for qemu-devel@nongnu.org; Wed, 25 Sep 2013 07:25:48 -0400
Date: Wed, 25 Sep 2013 13:25:39 +0200
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20130925112539.GD2898@dhcp-200-207.str.redhat.com>
References: <1380035224-7364-1-git-send-email-benoit@irqsave.net>
	<1380035224-7364-2-git-send-email-benoit@irqsave.net>
	<5241AE08.1030400@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <5241AE08.1030400@redhat.com>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH V4] block: introduce
 BlockDriver.bdrv_needs_filename to enable some drivers.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: =?iso-8859-1?Q?Beno=EEt?= Canet <benoit@irqsave.net>, stefanha@redhat.com, qemu-devel@nongnu.org

Am 24.09.2013 um 17:21 hat Eric Blake geschrieben:
> On 09/24/2013 09:07 AM, Beno=EEt Canet wrote:
> > Some drivers will have driver specifics options but no filename.
> > This new bool allow the block layer to treat them correctly.
> >=20
> > The .bdrv_needs_filename is set in drivers not having .bdrv_parse_fil=
ename and
> > not having .bdrv_open.
> >=20
> > The first exception to this rule will be the quorum driver.
> >=20
> > Signed-off-by: Benoit Canet <benoit@irqsave.net>
> > ---
> >  block.c                   | 5 +++--
> >  block/gluster.c           | 4 ++++
> >  block/iscsi.c             | 1 +
> >  block/raw-posix.c         | 5 +++++
> >  block/raw-win32.c         | 2 ++
> >  block/rbd.c               | 1 +
> >  block/sheepdog.c          | 3 +++
> >  include/block/block_int.h | 6 ++++++
> >  8 files changed, 25 insertions(+), 2 deletions(-)
>=20
> Reviewed-by: Eric Blake <eblake@redhat.com>

Thanks, applied to the block branch (with manual conflict resolution)

Kevin