From: "Michael S. Tsirkin" <mst@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org,
Anthony Liguori <anthony@codemonkey.ws>,
afaerber@suse.de
Subject: Re: [Qemu-devel] [PATCH v5 00/23] qemu: generate acpi tables for the guest
Date: Wed, 25 Sep 2013 15:59:48 +0300 [thread overview]
Message-ID: <20130925125948.GB19453@redhat.com> (raw)
In-Reply-To: <1380113332.3625.45.camel@nilsson.home.kraxel.org>
On Wed, Sep 25, 2013 at 02:48:52PM +0200, Gerd Hoffmann wrote:
> On Mi, 2013-09-25 at 14:22 +0300, Michael S. Tsirkin wrote:
> > This code can also be found here:
> > git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git acpi
> >
> > While this patch still uses info not available in QOM, I think it's reasonable
> > to merge it and then refactor as QOM properties cover more ground.
>
> Testing with coreboot (-M pc only so far, -M q35 tbd).
>
> [root@fedora ~]# cat /proc/ioports
> [ ... ]
> afe0-afe3 : ACPI GPE0_BLK
> b010-b015 : ACPI CPU throttle
> b100-b10f : 0000:00:01.3
> b100-b107 : piix4_smbus
> e400-e43f : 0000:00:01.3
> e400-e403 : ACPI PM1a_EVT_BLK
> e404-e405 : ACPI PM1a_CNT_BLK
> e408-e40b : ACPI PM_TMR
>
> "ACPI CPU throttle" looks wrong, probably hardcoded to 0xb010 instead of
> pmbase+0x10.
Hmm hardcoded where? Do you know where this comes from?
> Otherwise it looks good so far.
>
> cheers,
> Gerd
>
>
next prev parent reply other threads:[~2013-09-25 12:57 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-25 11:22 [Qemu-devel] [PATCH v5 00/23] qemu: generate acpi tables for the guest Michael S. Tsirkin
2013-09-25 11:22 ` [Qemu-devel] [PATCH v5 01/23] qemu: add Error to typedefs Michael S. Tsirkin
2013-09-25 11:23 ` [Qemu-devel] [PATCH v5 02/23] qom: pull in qemu/typedefs Michael S. Tsirkin
2013-09-25 11:23 ` [Qemu-devel] [PATCH v5 03/23] qom: cleanup struct Error references Michael S. Tsirkin
2013-09-25 11:23 ` [Qemu-devel] [PATCH v5 04/23] qom: add pointer to int property helpers Michael S. Tsirkin
2013-09-25 11:23 ` [Qemu-devel] [PATCH v5 05/23] fw_cfg: interface to trigger callback on read Michael S. Tsirkin
2013-09-25 11:23 ` [Qemu-devel] [PATCH v5 06/23] loader: support for unmapped ROM blobs Michael S. Tsirkin
2013-09-25 11:23 ` [Qemu-devel] [PATCH v5 07/23] pcie_host: expose UNMAPPED macro Michael S. Tsirkin
2013-09-25 11:23 ` [Qemu-devel] [PATCH v5 08/23] pcie_host: expose address format Michael S. Tsirkin
2013-09-25 11:23 ` [Qemu-devel] [PATCH v5 09/23] q35: use macro for MCFG property name Michael S. Tsirkin
2013-09-25 11:23 ` [Qemu-devel] [PATCH v5 10/23] q35: expose mmcfg size as a property Michael S. Tsirkin
2013-09-25 11:23 ` [Qemu-devel] [PATCH v5 11/23] i386: add ACPI table files from seabios Michael S. Tsirkin
2013-09-25 11:23 ` [Qemu-devel] [PATCH v5 12/23] acpi: add rules to compile ASL source Michael S. Tsirkin
2013-09-25 11:23 ` [Qemu-devel] [PATCH v5 13/23] acpi: pre-compiled ASL files Michael S. Tsirkin
2013-09-25 11:23 ` [Qemu-devel] [PATCH v5 14/23] loader: use file path size from fw_cfg.h Michael S. Tsirkin
2013-09-25 11:23 ` [Qemu-devel] [PATCH v5 15/23] i386: add bios linker/loader Michael S. Tsirkin
2013-09-25 11:23 ` [Qemu-devel] [PATCH v5 16/23] loader: allow adding ROMs in done callbacks Michael S. Tsirkin
2013-09-25 11:23 ` [Qemu-devel] [PATCH v5 17/23] i386: define pc guest info Michael S. Tsirkin
2013-09-25 11:23 ` [Qemu-devel] [PATCH v5 18/23] acpi/piix: add macros for acpi property names Michael S. Tsirkin
2013-09-25 11:24 ` [Qemu-devel] [PATCH v5 19/23] piix: APIs for pc guest info Michael S. Tsirkin
2013-09-25 11:24 ` [Qemu-devel] [PATCH v5 20/23] ich9: " Michael S. Tsirkin
2013-09-25 11:24 ` [Qemu-devel] [PATCH v5 21/23] pvpanic: add API to access io port Michael S. Tsirkin
2013-09-25 11:24 ` [Qemu-devel] [PATCH v5 22/23] hpet: add API to find it Michael S. Tsirkin
2013-09-25 11:24 ` [Qemu-devel] [PATCH v5 23/23] i386: ACPI table generation code from seabios Michael S. Tsirkin
2013-09-25 12:48 ` [Qemu-devel] [PATCH v5 00/23] qemu: generate acpi tables for the guest Gerd Hoffmann
2013-09-25 12:59 ` Michael S. Tsirkin [this message]
2013-09-25 13:02 ` Gerd Hoffmann
2013-09-25 13:09 ` Michael S. Tsirkin
2013-09-25 13:26 ` Gerd Hoffmann
2013-09-26 22:18 ` Michael S. Tsirkin
2013-09-27 9:34 ` Gerd Hoffmann
2013-09-25 13:03 ` Michael S. Tsirkin
2013-09-25 13:12 ` Gerd Hoffmann
2013-09-25 14:15 ` Gerd Hoffmann
2013-09-25 14:48 ` Michael S. Tsirkin
2013-09-26 6:26 ` Gerd Hoffmann
2013-09-26 21:33 ` Michael S. Tsirkin
2013-09-26 21:50 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130925125948.GB19453@redhat.com \
--to=mst@redhat.com \
--cc=afaerber@suse.de \
--cc=anthony@codemonkey.ws \
--cc=kraxel@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).