From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49984)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1VOof2-0001oj-B4
	for qemu-devel@nongnu.org; Wed, 25 Sep 2013 08:57:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1VOoeu-0008QC-8e
	for qemu-devel@nongnu.org; Wed, 25 Sep 2013 08:57:44 -0400
Received: from mx1.redhat.com ([209.132.183.28]:12967)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1VOoeu-0008Q4-0S
	for qemu-devel@nongnu.org; Wed, 25 Sep 2013 08:57:36 -0400
Date: Wed, 25 Sep 2013 15:59:48 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20130925125948.GB19453@redhat.com>
References: <1380108120-18700-1-git-send-email-mst@redhat.com>
	<1380113332.3625.45.camel@nilsson.home.kraxel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1380113332.3625.45.camel@nilsson.home.kraxel.org>
Subject: Re: [Qemu-devel] [PATCH v5 00/23] qemu: generate acpi tables for
	the guest
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>, afaerber@suse.de

On Wed, Sep 25, 2013 at 02:48:52PM +0200, Gerd Hoffmann wrote:
> On Mi, 2013-09-25 at 14:22 +0300, Michael S. Tsirkin wrote:
> > This code can also be found here:
> > git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git acpi
> > 
> > While this patch still uses info not available in QOM, I think it's reasonable
> > to merge it and then refactor as QOM properties cover more ground.
> 
> Testing with coreboot (-M pc only so far, -M q35 tbd).
> 
> [root@fedora ~]# cat /proc/ioports 
>   [ ... ]
>   afe0-afe3 : ACPI GPE0_BLK
>   b010-b015 : ACPI CPU throttle
>   b100-b10f : 0000:00:01.3
>     b100-b107 : piix4_smbus
>   e400-e43f : 0000:00:01.3
>     e400-e403 : ACPI PM1a_EVT_BLK
>     e404-e405 : ACPI PM1a_CNT_BLK
>     e408-e40b : ACPI PM_TMR
> 
> "ACPI CPU throttle" looks wrong, probably hardcoded to 0xb010 instead of
> pmbase+0x10.

Hmm hardcoded where? Do you know where this comes from?

> Otherwise it looks good so far.
> 
> cheers,
>   Gerd
> 
>