From: Kevin Wolf <kwolf@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: qemu-stable@nongnu.org, qemu-devel@nongnu.org,
Michael Roth <mdroth@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH v2] rbd: avoid qemu_rbd_snap_list() memory leaks
Date: Wed, 25 Sep 2013 16:23:27 +0200 [thread overview]
Message-ID: <20130925142327.GG2898@dhcp-200-207.str.redhat.com> (raw)
In-Reply-To: <1380117648-17625-1-git-send-email-stefanha@redhat.com>
Am 25.09.2013 um 16:00 hat Stefan Hajnoczi geschrieben:
> When there are no snapshots qemu_rbd_snap_list() returns 0 and the
> snapshot table pointer is NULL. Don't forget to free the snaps buffer
> we allocated for librbd rbd_snap_list().
>
> When the function succeeds don't forget to free the snaps buffer after
> calling rbd_snap_list_end().
>
> Cc: qemu-stable@nongnu.org
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Thanks, updated the block branch with this.
Kevin
prev parent reply other threads:[~2013-09-25 14:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-25 14:00 [Qemu-devel] [PATCH v2] rbd: avoid qemu_rbd_snap_list() memory leaks Stefan Hajnoczi
2013-09-25 14:23 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130925142327.GG2898@dhcp-200-207.str.redhat.com \
--to=kwolf@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).