From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47990)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1VOq0j-00043A-8x
	for qemu-devel@nongnu.org; Wed, 25 Sep 2013 10:24:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1VOq0d-0003PV-IB
	for qemu-devel@nongnu.org; Wed, 25 Sep 2013 10:24:13 -0400
Date: Wed, 25 Sep 2013 16:23:27 +0200
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20130925142327.GG2898@dhcp-200-207.str.redhat.com>
References: <1380117648-17625-1-git-send-email-stefanha@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1380117648-17625-1-git-send-email-stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2] rbd: avoid qemu_rbd_snap_list() memory
	leaks
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: qemu-stable@nongnu.org, qemu-devel@nongnu.org, Michael Roth <mdroth@linux.vnet.ibm.com>

Am 25.09.2013 um 16:00 hat Stefan Hajnoczi geschrieben:
> When there are no snapshots qemu_rbd_snap_list() returns 0 and the
> snapshot table pointer is NULL.  Don't forget to free the snaps buffer
> we allocated for librbd rbd_snap_list().
> 
> When the function succeeds don't forget to free the snaps buffer after
> calling rbd_snap_list_end().
> 
> Cc: qemu-stable@nongnu.org
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>

Thanks, updated the block branch with this.

Kevin