From: "Benoît Canet" <benoit.canet@irqsave.net>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [RFC V8 03/13] quorum: Add quorum_aio_writev and its dependencies.
Date: Thu, 26 Sep 2013 18:16:55 +0200 [thread overview]
Message-ID: <20130926161655.GD3338@irqsave.net> (raw)
In-Reply-To: <5114D5AE.6070901@redhat.com>
> > +static void quorum_aio_bh(void *opaque)
> > +{
> > + QuorumAIOCB *acb = opaque;
> > + BDRVQuorumState *s = acb->bqs;
> > + int ret;
> > +
> > + ret = s->threshold <= acb->success_count ? 0 : -EIO;
>
> It would be very much preferable if you stored the actual error code
> instead of turning everything into -EIO.
I am turning everything into -EIO because multiple errors can happen at the same
time.
Best regards
Benoît
next prev parent reply other threads:[~2013-09-26 16:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1359392845-15905-1-git-send-email-benoit@irqsave.net>
[not found] ` <1359392845-15905-4-git-send-email-benoit@irqsave.net>
[not found] ` <5114D5AE.6070901@redhat.com>
2013-09-26 15:25 ` [Qemu-devel] [RFC V8 03/13] quorum: Add quorum_aio_writev and its dependencies Benoît Canet
2013-09-26 16:16 ` Benoît Canet [this message]
2013-09-27 9:59 ` Kevin Wolf
2013-09-26 16:29 ` Benoît Canet
2013-09-27 10:03 ` Kevin Wolf
2013-09-30 12:54 ` Benoît Canet
[not found] ` <1359392845-15905-7-git-send-email-benoit@irqsave.net>
[not found] ` <5114EA67.5000308@redhat.com>
2013-09-26 16:46 ` [Qemu-devel] [RFC V8 06/13] quorum: Add quorum mechanism Benoît Canet
2013-09-27 10:05 ` Kevin Wolf
2013-09-30 12:58 ` Benoît Canet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130926161655.GD3338@irqsave.net \
--to=benoit.canet@irqsave.net \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).