From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51098)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1VPEFV-0002Lo-L2
	for qemu-devel@nongnu.org; Thu, 26 Sep 2013 12:17:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1VPEFP-0004Ne-8p
	for qemu-devel@nongnu.org; Thu, 26 Sep 2013 12:17:05 -0400
Received: from nodalink.pck.nerim.net ([62.212.105.220]:39683
	helo=paradis.irqsave.net) by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1VPEFO-0004NS-W4
	for qemu-devel@nongnu.org; Thu, 26 Sep 2013 12:16:59 -0400
Date: Thu, 26 Sep 2013 18:16:55 +0200
From: =?iso-8859-1?Q?Beno=EEt?= Canet <benoit.canet@irqsave.net>
Message-ID: <20130926161655.GD3338@irqsave.net>
References: <1359392845-15905-1-git-send-email-benoit@irqsave.net>
	<1359392845-15905-4-git-send-email-benoit@irqsave.net>
	<5114D5AE.6070901@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <5114D5AE.6070901@redhat.com>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [RFC V8 03/13] quorum: Add quorum_aio_writev and
 its dependencies.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org, stefanha@redhat.com

> > +static void quorum_aio_bh(void *opaque)
> > +{
> > +    QuorumAIOCB *acb =3D opaque;
> > +    BDRVQuorumState *s =3D acb->bqs;
> > +    int ret;
> > +
> > +    ret =3D s->threshold <=3D acb->success_count ? 0 : -EIO;
>=20
> It would be very much preferable if you stored the actual error code
> instead of turning everything into -EIO.

I am turning everything into -EIO because multiple errors can happen at t=
he same
time.

Best regards

Beno=EEt