From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36954)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1VPJ9Q-0003Gj-Un
	for qemu-devel@nongnu.org; Thu, 26 Sep 2013 17:31:14 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1VPJ9H-0001Qy-Ft
	for qemu-devel@nongnu.org; Thu, 26 Sep 2013 17:31:08 -0400
Received: from mx1.redhat.com ([209.132.183.28]:65467)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1VPJ9H-0001QV-8n
	for qemu-devel@nongnu.org; Thu, 26 Sep 2013 17:30:59 -0400
Date: Fri, 27 Sep 2013 00:33:15 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20130926213315.GA25615@redhat.com>
References: <1380108120-18700-1-git-send-email-mst@redhat.com>
	<1380114776.3625.50.camel@nilsson.home.kraxel.org>
	<1380118503.3625.86.camel@nilsson.home.kraxel.org>
	<20130925144850.GA29330@redhat.com>
	<1380176811.11024.5.camel@nilsson.home.kraxel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1380176811.11024.5.camel@nilsson.home.kraxel.org>
Subject: Re: [Qemu-devel] [PATCH v5 00/23] qemu: generate acpi tables for
	the guest
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>, afaerber@suse.de

On Thu, Sep 26, 2013 at 08:26:51AM +0200, Gerd Hoffmann wrote:
>   Hi,
> 
> > diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
> > index 1ba86d0..d1ccdf7 100644
> > --- a/hw/i386/acpi-build.c
> > +++ b/hw/i386/acpi-build.c
> > @@ -961,8 +961,8 @@ static void acpi_build_update(void *build_opaque, uint32_t offset)
> >      if (build_state->mcfg_base) {
> >          AcpiMcfgAllocation *a;
> >          mcfg_base = qint_get_int(build_state->mcfg_base);
> > +        assert(build_state->mcfg_size);
> >          mcfg_size = qint_get_int(build_state->mcfg_size);
> > -        assert(mcfg_size);
> >  
> >          a = ACPI_BUILD_STATE_PTR(build_state, off_mcfg_allocation,
> >                                   AcpiMcfgAllocation);
> 
> Well, that fixes the assert, but it still isn't working correctly.  No
> mcfg table in acpi, even though the mcfg bar is programmed correctly.
> 
> Seeing this with both seabios+coreboot.
> 
> cheers,
>   Gerd
> 

I see the bug now: my tests didn't check the MCFG table.

I'll fix this up, thanks!