From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44377) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VPJr7-0005W4-8c for qemu-devel@nongnu.org; Thu, 26 Sep 2013 18:16:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VPJr0-0005t5-RX for qemu-devel@nongnu.org; Thu, 26 Sep 2013 18:16:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:61329) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VPJr0-0005sv-IG for qemu-devel@nongnu.org; Thu, 26 Sep 2013 18:16:10 -0400 Date: Fri, 27 Sep 2013 01:18:26 +0300 From: "Michael S. Tsirkin" Message-ID: <20130926221826.GB26765@redhat.com> References: <1380108120-18700-1-git-send-email-mst@redhat.com> <1380113332.3625.45.camel@nilsson.home.kraxel.org> <20130925125948.GB19453@redhat.com> <1380114155.3625.46.camel@nilsson.home.kraxel.org> <20130925130946.GA19698@redhat.com> <1380115572.3625.58.camel@nilsson.home.kraxel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1380115572.3625.58.camel@nilsson.home.kraxel.org> Subject: Re: [Qemu-devel] [PATCH v5 00/23] qemu: generate acpi tables for the guest List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, Anthony Liguori , afaerber@suse.de On Wed, Sep 25, 2013 at 03:26:12PM +0200, Gerd Hoffmann wrote: > > > > > [root@fedora ~]# cat /proc/ioports > > > > > [ ... ] > > > > > afe0-afe3 : ACPI GPE0_BLK > > > > > b010-b015 : ACPI CPU throttle > > > > > b100-b10f : 0000:00:01.3 > > > > > b100-b107 : piix4_smbus > > > > > e400-e43f : 0000:00:01.3 > > > > > e400-e403 : ACPI PM1a_EVT_BLK > > > > > e404-e405 : ACPI PM1a_CNT_BLK > > > > > e408-e40b : ACPI PM_TMR > > > > > > > > > > "ACPI CPU throttle" looks wrong, probably hardcoded to 0xb010 instead of > > > > > pmbase+0x10. > > > > > > > > Hmm hardcoded where? Do you know where this comes from? > > > > > > [root@fedora acpi]# grep -i b010 *.dsl > > > SSDT.dsl: Processor (CP00, 0x00, 0x0000B010, 0x06) > > > > > > cheers, > > > Gerd > > > Sorry I wasn't clear. > > Where *should* the value come from? > > Does QEMU have any hardware at that address? > > It is part of the piix4 acpi bar, with seabios it looks like this: > > b000-b03f : 0000:00:01.3 > b000-b003 : ACPI PM1a_EVT_BLK > b004-b005 : ACPI PM1a_CNT_BLK > b008-b00b : ACPI PM_TMR > b010-b015 : ACPI CPU throttle > > I don't think we have virtual cpu throttling, as far I know nothing in > qemu does actually listens at that address. Maybe the CorrectThing[tm] > to do would be passing 0 there (not fully sure how to express "no power > management here" in acpi). > > cheers, > Gerd > > ACPI gives a way to do this: supply PBlockLength = 0. I applied the following: though this means bytecode is not 1:1 identical to what we have with seabios, so I will keep it as a separate commit. commit cbb0ddf058758e51a07cd77fcff22a286583d45b Author: Michael S. Tsirkin Date: Fri Sep 27 01:15:14 2013 +0300 ssdt: fix PBLK length We don't really support CPU throttling, so supply 0 PBLK length. Signed-off-by: Michael S. Tsirkin diff --git a/hw/i386/ssdt-proc.dsl b/hw/i386/ssdt-proc.dsl index 58333c7..8229bfd 100644 --- a/hw/i386/ssdt-proc.dsl +++ b/hw/i386/ssdt-proc.dsl @@ -37,7 +37,7 @@ DefinitionBlock ("ssdt-proc.aml", "SSDT", 0x01, "BXPC", "BXSSDT", 0x1) ACPI_EXTRACT_PROCESSOR_START ssdt_proc_start ACPI_EXTRACT_PROCESSOR_END ssdt_proc_end ACPI_EXTRACT_PROCESSOR_STRING ssdt_proc_name - Processor(CPAA, 0xAA, 0x0000b010, 0x06) { + Processor(CPAA, 0xAA, 0x00000000, 0x0) { ACPI_EXTRACT_NAME_BYTE_CONST ssdt_proc_id Name(ID, 0xAA) /* -- MST