From: Kevin Wolf <kwolf@redhat.com>
To: Max Reitz <mreitz@redhat.com>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/2] Correct bitmap size in zero cluster expansion
Date: Fri, 27 Sep 2013 11:23:00 +0200 [thread overview]
Message-ID: <20130927092300.GC2440@dhcp-200-207.str.redhat.com> (raw)
In-Reply-To: <1380103643-30419-1-git-send-email-mreitz@redhat.com>
Am 25.09.2013 um 12:07 hat Max Reitz geschrieben:
> The current version of the zero cluster expansion uses the guest disk
> size for determining the size of the expanded_clusters bitmap, however,
> it is addressed using host offsets. This leads to an assertion failing if
> the host image size exceeds the guest disk size. This is fixed by using
> the host image size instead for allocating the bitmap.
>
> This however uncovers another problem: If the host image is growable, it
> may grow during the zero cluster expansion due to cluster allocations. If
> this happens, the bitmap has to be resized accordingly.
>
> Max Reitz (2):
> qcow2: Correct bitmap size in zero expansion
> qemu-iotests: Preallocated zero clusters in 061
>
> block/qcow2-cluster.c | 38 +++++++++++++++++++++++++++-----------
> tests/qemu-iotests/061 | 9 +++++++++
> tests/qemu-iotests/061.out | 11 +++++++++++
> 3 files changed, 47 insertions(+), 11 deletions(-)
Thanks, applied to the block branch.
Kevin
prev parent reply other threads:[~2013-09-27 9:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-25 10:07 [Qemu-devel] [PATCH 0/2] Correct bitmap size in zero cluster expansion Max Reitz
2013-09-25 10:07 ` [Qemu-devel] [PATCH 1/2] qcow2: Correct bitmap size in zero expansion Max Reitz
2013-09-25 10:07 ` [Qemu-devel] [PATCH 2/2] qemu-iotests: Preallocated zero clusters in 061 Max Reitz
2013-09-27 9:23 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130927092300.GC2440@dhcp-200-207.str.redhat.com \
--to=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).