From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49937) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VPUGS-0003Zy-Cd for qemu-devel@nongnu.org; Fri, 27 Sep 2013 05:23:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VPUGM-0006wd-Dv for qemu-devel@nongnu.org; Fri, 27 Sep 2013 05:23:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34428) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VPUGM-0006wR-7N for qemu-devel@nongnu.org; Fri, 27 Sep 2013 05:23:02 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r8R9N1RM013988 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 27 Sep 2013 05:23:01 -0400 Date: Fri, 27 Sep 2013 11:23:00 +0200 From: Kevin Wolf Message-ID: <20130927092300.GC2440@dhcp-200-207.str.redhat.com> References: <1380103643-30419-1-git-send-email-mreitz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1380103643-30419-1-git-send-email-mreitz@redhat.com> Subject: Re: [Qemu-devel] [PATCH 0/2] Correct bitmap size in zero cluster expansion List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: qemu-devel@nongnu.org, Stefan Hajnoczi Am 25.09.2013 um 12:07 hat Max Reitz geschrieben: > The current version of the zero cluster expansion uses the guest disk > size for determining the size of the expanded_clusters bitmap, however, > it is addressed using host offsets. This leads to an assertion failing if > the host image size exceeds the guest disk size. This is fixed by using > the host image size instead for allocating the bitmap. > > This however uncovers another problem: If the host image is growable, it > may grow during the zero cluster expansion due to cluster allocations. If > this happens, the bitmap has to be resized accordingly. > > Max Reitz (2): > qcow2: Correct bitmap size in zero expansion > qemu-iotests: Preallocated zero clusters in 061 > > block/qcow2-cluster.c | 38 +++++++++++++++++++++++++++----------- > tests/qemu-iotests/061 | 9 +++++++++ > tests/qemu-iotests/061.out | 11 +++++++++++ > 3 files changed, 47 insertions(+), 11 deletions(-) Thanks, applied to the block branch. Kevin