From: Kevin Wolf <kwolf@redhat.com>
To: Max Reitz <mreitz@redhat.com>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] qcow2: count_contiguous_clusters and compression
Date: Fri, 27 Sep 2013 11:31:10 +0200 [thread overview]
Message-ID: <20130927093110.GD2440@dhcp-200-207.str.redhat.com> (raw)
In-Reply-To: <1380124032-20803-1-git-send-email-mreitz@redhat.com>
Am 25.09.2013 um 17:47 hat Max Reitz geschrieben:
> The function is not intended to be used on compressed clusters and will
> not work correctly, if used anyway, since L2E_OFFSET_MASK is not the
> right mask for determining the offset of compressed clusters. Therefore,
> assert that the first cluster is not compressed and always include the
> compression flag in the mask of significant flags, i.e., stop the search
> as soon as a compressed cluster occurs.
>
> Signed-off-by: Max Reitz <mreitz@redhat.com>
This is supposed to be a cleanup patch with no functional change, right?
How about removing explicit QCOW_OFLAG_COMPRESSED arguments from
callers?
Kevin
prev parent reply other threads:[~2013-09-27 9:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-25 15:47 [Qemu-devel] [PATCH] qcow2: count_contiguous_clusters and compression Max Reitz
2013-09-27 9:31 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130927093110.GD2440@dhcp-200-207.str.redhat.com \
--to=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).