qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Max Reitz <mreitz@redhat.com>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/3] qcow2: Small error path fixes for l2_allocate
Date: Fri, 27 Sep 2013 11:38:20 +0200	[thread overview]
Message-ID: <20130927093820.GE2440@dhcp-200-207.str.redhat.com> (raw)
In-Reply-To: <1380119840-12672-1-git-send-email-mreitz@redhat.com>

Am 25.09.2013 um 16:37 hat Max Reitz geschrieben:
> Errors in l2_allocate should always go down the error path. If this path
> is taken, the newly allocated L2 cluster is abandoned and should thus be
> freed. The L2 table on the other hand should only be put back into the
> cache if it was taken from it before.
> 
> Max Reitz (3):
>   qcow2: Don't put invalid L2 table into cache
>   qcow2: Free allocated L2 cluster on error
>   qcow2: Always use error path in l2_allocate
> 
>  block/qcow2-cluster.c | 15 +++++++++++----
>  1 file changed, 11 insertions(+), 4 deletions(-)

Thanks, applied all to the block branch.

Kevin

      parent reply	other threads:[~2013-09-27  9:38 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-25 14:37 [Qemu-devel] [PATCH 0/3] qcow2: Small error path fixes for l2_allocate Max Reitz
2013-09-25 14:37 ` [Qemu-devel] [PATCH 1/3] qcow2: Don't put invalid L2 table into cache Max Reitz
2013-09-25 14:47   ` Benoît Canet
2013-09-25 14:37 ` [Qemu-devel] [PATCH 2/3] qcow2: Free allocated L2 cluster on error Max Reitz
2013-09-25 14:50   ` Benoît Canet
2013-09-27 14:54   ` Kevin Wolf
2013-09-30  9:48     ` Max Reitz
2013-09-30 11:24       ` Kevin Wolf
2013-09-25 14:37 ` [Qemu-devel] [PATCH 3/3] qcow2: Always use error path in l2_allocate Max Reitz
2013-09-25 14:56   ` Benoît Canet
2013-09-27  9:38 ` Kevin Wolf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130927093820.GE2440@dhcp-200-207.str.redhat.com \
    --to=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).