From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52955)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1VPUVJ-0000Wi-Jk
	for qemu-devel@nongnu.org; Fri, 27 Sep 2013 05:38:35 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1VPUVC-00030R-Hb
	for qemu-devel@nongnu.org; Fri, 27 Sep 2013 05:38:29 -0400
Received: from mx1.redhat.com ([209.132.183.28]:26306)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1VPUVC-00030E-AU
	for qemu-devel@nongnu.org; Fri, 27 Sep 2013 05:38:22 -0400
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
	(int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r8R9cLj1023001
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Fri, 27 Sep 2013 05:38:21 -0400
Date: Fri, 27 Sep 2013 11:38:20 +0200
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20130927093820.GE2440@dhcp-200-207.str.redhat.com>
References: <1380119840-12672-1-git-send-email-mreitz@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1380119840-12672-1-git-send-email-mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/3] qcow2: Small error path fixes for
	l2_allocate
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Max Reitz <mreitz@redhat.com>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>

Am 25.09.2013 um 16:37 hat Max Reitz geschrieben:
> Errors in l2_allocate should always go down the error path. If this path
> is taken, the newly allocated L2 cluster is abandoned and should thus be
> freed. The L2 table on the other hand should only be put back into the
> cache if it was taken from it before.
> 
> Max Reitz (3):
>   qcow2: Don't put invalid L2 table into cache
>   qcow2: Free allocated L2 cluster on error
>   qcow2: Always use error path in l2_allocate
> 
>  block/qcow2-cluster.c | 15 +++++++++++----
>  1 file changed, 11 insertions(+), 4 deletions(-)

Thanks, applied all to the block branch.

Kevin