From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47095) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VPWKo-0005cR-13 for qemu-devel@nongnu.org; Fri, 27 Sep 2013 07:35:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VPWKh-00042k-U1 for qemu-devel@nongnu.org; Fri, 27 Sep 2013 07:35:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47031) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VPWKh-00042N-NU for qemu-devel@nongnu.org; Fri, 27 Sep 2013 07:35:39 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r8RBZbWP008289 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 27 Sep 2013 07:35:38 -0400 Date: Fri, 27 Sep 2013 07:35:35 -0400 From: Jeff Cody Message-ID: <20130927113535.GA26778@localhost.localdomain> References: <20130927091455.GA2440@dhcp-200-207.str.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130927091455.GA2440@dhcp-200-207.str.redhat.com> Subject: Re: [Qemu-devel] [PATCH v3 2/3] block: qemu-iotests for vhdx, read sample dynamic image List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org, stefanha@redhat.com On Fri, Sep 27, 2013 at 11:14:55AM +0200, Kevin Wolf wrote: > Am 25.09.2013 um 14:12 hat Jeff Cody geschrieben: > > This adds the VHDX format to the qemu-iotests format, and adds > > a read test. The test reads from an existing sample image, that > > was created with Hyper-V under Windwos Server 2012. > > > > The image file is a 1GB dynamic image, with 32MB blocks. > > > > The pattern 0xa5 exists from 0MB-33MB (past a block size boundary) > > > > The pattern 0x96 exists from 33MB-66MB (past another block boundary, > > and leaving a partial blank block) > > > > From 66MB-1024MB, all reads should return 0. > > > > Although 1GB dynamic image with 66MB of data, the bzip2'ed image > > file size is only 874 bytes. > > > > Signed-off-by: Jeff Cody > > Reviewed-by: Stefan Hajnoczi > > > diff --git a/tests/qemu-iotests/064.out b/tests/qemu-iotests/064.out > > new file mode 100644 > > index 0000000..b9e8e4a > > --- /dev/null > > +++ b/tests/qemu-iotests/064.out > > @@ -0,0 +1,14 @@ > > +QA output created by 064 > > + > > +=== Verify pattern 0xa5, 0 - 33MB === > > +read 34603008/34603008 bytes at offset 0 > > +33 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) > > + > > +=== Verify pattern 0x96, 33M - 66M === > > +read 34603008/34603008 bytes at offset 34603008 > > +33 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) > > + > > +=== Verify pattern 0x00, 66M - 1024M === > > +read 1004535808/1004535808 bytes at offset 69206016 > > +958 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) > > +*** done > > Doesn't work for me. Am I missing patches that need to be applied first? > I need to add -r to the QEMU_IO arguments. I had tested this on my rebased vhdx branch, which has r/w support, so I missed that. QEMU on qemu/master will refuse to open a VHDX image r/w. Submitting a v4 with this change (just this patch since you applied the other two) > 064 1s ... [11:09:58] [11:09:59] - output mismatch (see 064.out.bad) > --- 064.out 2013-09-27 11:00:37.077677734 +0200 > +++ 064.out.bad 2013-09-27 11:09:59.704298133 +0200 > @@ -1,14 +1,14 @@ > QA output created by 064 > > === Verify pattern 0xa5, 0 - 33MB === > -read 34603008/34603008 bytes at offset 0 > -33 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) > +qemu-io: can't open device /home/kwolf/source/qemu/tests/qemu-iotests/scratch/iotest-dynamic-1G.vhdx: Could not open '/home/kwolf/source/qemu/tests/qemu-iotests/scratch/iotest-dynamic-1G.vhdx': Operation not supported > +no file open, try 'help open' > > === Verify pattern 0x96, 33M - 66M === > -read 34603008/34603008 bytes at offset 34603008 > -33 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) > +qemu-io: can't open device /home/kwolf/source/qemu/tests/qemu-iotests/scratch/iotest-dynamic-1G.vhdx: Could not open '/home/kwolf/source/qemu/tests/qemu-iotests/scratch/iotest-dynamic-1G.vhdx': Operation not supported > +no file open, try 'help open' > > === Verify pattern 0x00, 66M - 1024M === > -read 1004535808/1004535808 bytes at offset 69206016 > -958 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) > +qemu-io: can't open device /home/kwolf/source/qemu/tests/qemu-iotests/scratch/iotest-dynamic-1G.vhdx: Could not open '/home/kwolf/source/qemu/tests/qemu-iotests/scratch/iotest-dynamic-1G.vhdx': Operation not supported > +no file open, try 'help open' > *** done > > Kevin >