From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59418) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VPYco-0004d3-OT for qemu-devel@nongnu.org; Fri, 27 Sep 2013 10:02:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VPYcf-0001gN-Mq for qemu-devel@nongnu.org; Fri, 27 Sep 2013 10:02:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:64859) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VPYcf-0001g9-EV for qemu-devel@nongnu.org; Fri, 27 Sep 2013 10:02:21 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r8RE2JHR024224 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 27 Sep 2013 10:02:20 -0400 Date: Fri, 27 Sep 2013 10:02:17 -0400 From: Jeff Cody Message-ID: <20130927140217.GC26778@localhost.localdomain> References: <1380282670-5059-1-git-send-email-kwolf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1380282670-5059-1-git-send-email-kwolf@redhat.com> Subject: Re: [Qemu-devel] [PATCH] qcow2: Remove useless count_contiguous_clusters() parameter List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org On Fri, Sep 27, 2013 at 01:51:10PM +0200, Kevin Wolf wrote: > All callers pass start = 0, and it's doubtful if any other value would > actually do what you expect. Remove the parameter. > > Signed-off-by: Kevin Wolf Reviewed-by: Jeff Cody > --- > block/qcow2-cluster.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c > index 029c805..72cb573 100644 > --- a/block/qcow2-cluster.c > +++ b/block/qcow2-cluster.c > @@ -285,7 +285,7 @@ fail: > * cluster which may require a different handling) > */ > static int count_contiguous_clusters(uint64_t nb_clusters, int cluster_size, > - uint64_t *l2_table, uint64_t start, uint64_t stop_flags) > + uint64_t *l2_table, uint64_t stop_flags) > { > int i; > uint64_t mask = stop_flags | L2E_OFFSET_MASK | QCOW2_CLUSTER_COMPRESSED; > @@ -297,14 +297,14 @@ static int count_contiguous_clusters(uint64_t nb_clusters, int cluster_size, > > assert(qcow2_get_cluster_type(first_entry) != QCOW2_CLUSTER_COMPRESSED); > > - for (i = start; i < start + nb_clusters; i++) { > + for (i = 0; i < nb_clusters; i++) { > uint64_t l2_entry = be64_to_cpu(l2_table[i]) & mask; > if (offset + (uint64_t) i * cluster_size != l2_entry) { > break; > } > } > > - return (i - start); > + return i; > } > > static int count_contiguous_free_clusters(uint64_t nb_clusters, uint64_t *l2_table) > @@ -497,7 +497,7 @@ int qcow2_get_cluster_offset(BlockDriverState *bs, uint64_t offset, > return -EIO; > } > c = count_contiguous_clusters(nb_clusters, s->cluster_size, > - &l2_table[l2_index], 0, QCOW_OFLAG_ZERO); > + &l2_table[l2_index], QCOW_OFLAG_ZERO); > *cluster_offset = 0; > break; > case QCOW2_CLUSTER_UNALLOCATED: > @@ -508,7 +508,7 @@ int qcow2_get_cluster_offset(BlockDriverState *bs, uint64_t offset, > case QCOW2_CLUSTER_NORMAL: > /* how many allocated clusters ? */ > c = count_contiguous_clusters(nb_clusters, s->cluster_size, > - &l2_table[l2_index], 0, QCOW_OFLAG_ZERO); > + &l2_table[l2_index], QCOW_OFLAG_ZERO); > *cluster_offset &= L2E_OFFSET_MASK; > break; > default: > @@ -938,7 +938,7 @@ static int handle_copied(BlockDriverState *bs, uint64_t guest_offset, > /* We keep all QCOW_OFLAG_COPIED clusters */ > keep_clusters = > count_contiguous_clusters(nb_clusters, s->cluster_size, > - &l2_table[l2_index], 0, > + &l2_table[l2_index], > QCOW_OFLAG_COPIED | QCOW_OFLAG_ZERO); > assert(keep_clusters <= nb_clusters); > > -- > 1.8.1.4 > >