From: Kevin Wolf <kwolf@redhat.com>
To: Max Reitz <mreitz@redhat.com>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/3] qcow2: Free allocated L2 cluster on error
Date: Fri, 27 Sep 2013 16:54:52 +0200 [thread overview]
Message-ID: <20130927145452.GA4510@dhcp-200-207.str.redhat.com> (raw)
In-Reply-To: <1380119840-12672-3-git-send-email-mreitz@redhat.com>
Am 25.09.2013 um 16:37 hat Max Reitz geschrieben:
> If an error occurs in l2_allocate, the allocated (but unused) L2 cluster
> should be freed.
>
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
> block/qcow2-cluster.c | 4 ++++
> 1 file changed, 4 insertions(+)
This needs an update of the reference output for test case 026 (both for
-nocache and writethrough).
Most of the changes look expected and good, like cluster leaks
disappearing. With -nocache, however, there are a few cases that failed
previously and result in successful writes now. It would be interesting
to see the explanation for these before we merge the patch.
Kevin
next prev parent reply other threads:[~2013-09-27 14:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-25 14:37 [Qemu-devel] [PATCH 0/3] qcow2: Small error path fixes for l2_allocate Max Reitz
2013-09-25 14:37 ` [Qemu-devel] [PATCH 1/3] qcow2: Don't put invalid L2 table into cache Max Reitz
2013-09-25 14:47 ` Benoît Canet
2013-09-25 14:37 ` [Qemu-devel] [PATCH 2/3] qcow2: Free allocated L2 cluster on error Max Reitz
2013-09-25 14:50 ` Benoît Canet
2013-09-27 14:54 ` Kevin Wolf [this message]
2013-09-30 9:48 ` Max Reitz
2013-09-30 11:24 ` Kevin Wolf
2013-09-25 14:37 ` [Qemu-devel] [PATCH 3/3] qcow2: Always use error path in l2_allocate Max Reitz
2013-09-25 14:56 ` Benoît Canet
2013-09-27 9:38 ` [Qemu-devel] [PATCH 0/3] qcow2: Small error path fixes for l2_allocate Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130927145452.GA4510@dhcp-200-207.str.redhat.com \
--to=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).