From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39374) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VPapd-0001O7-9t for Qemu-devel@nongnu.org; Fri, 27 Sep 2013 12:24:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VPapU-0005UP-RF for Qemu-devel@nongnu.org; Fri, 27 Sep 2013 12:23:53 -0400 Received: from mail-ob0-x236.google.com ([2607:f8b0:4003:c01::236]:42316) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VPapU-0005UK-Lv for Qemu-devel@nongnu.org; Fri, 27 Sep 2013 12:23:44 -0400 Received: by mail-ob0-f182.google.com with SMTP id wo20so3374891obc.13 for ; Fri, 27 Sep 2013 09:23:44 -0700 (PDT) Sender: fluxion Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Michael Roth In-Reply-To: <1380160635-15715-1-git-send-email-wudxw@linux.vnet.ibm.com> References: <1380160635-15715-1-git-send-email-wudxw@linux.vnet.ibm.com> Message-ID: <20130927162341.20300.1860@loki> Date: Fri, 27 Sep 2013 11:23:41 -0500 Subject: Re: [Qemu-devel] [PATCH v3] Extend qemu-ga's 'guest-info' command to expose flag 'success-response' List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mark Wu , Qemu-devel@nongnu.org Cc: Luiz Capitulino Quoting Mark Wu (2013-09-25 20:57:15) > Now we have several qemu-ga commands not returning response on success. > It has been documented in qga/qapi-schema.json already. This patch exposes > the 'success-response' flag by extending 'guest-info' command. With this > change, the clients can handle the command response more flexibly. > = > Signed-off-by: Mark Wu > --- > Changes: > v3: = > 1. treat cmd->options as a bitmask instead of single option (per= Eric) = > 2. rebase on the patch " Add interface to traverse the qmp comma= nd list > by QmpCommand" to avoid the O(n2) problem (per Eric and Michael) As per other patch, please include something like qmp_has_success_response() to avoid poking directly at cmd->options. Looks good otherwise. > v2: = > add the notation 'since 1.7' to the option 'success-response' > (per Eric Blake's comments) > = > qga/commands.c | 1 + > qga/qapi-schema.json | 5 ++++- > 2 files changed, 5 insertions(+), 1 deletion(-) > = > diff --git a/qga/commands.c b/qga/commands.c > index 602cd47..f70d0c4 100644 > --- a/qga/commands.c > +++ b/qga/commands.c > @@ -54,6 +54,7 @@ static void qmp_command_info(QmpCommand *cmd, void *opa= que) > cmd_info =3D g_malloc0(sizeof(GuestAgentCommandInfo)); > cmd_info->name =3D g_strdup(cmd->name); > cmd_info->enabled =3D cmd->enabled; > + cmd_info->success_response =3D !(cmd->options & QCO_NO_SUCCESS_RESP); > cmd_info_list =3D g_malloc0(sizeof(GuestAgentCommandInfoList)); > cmd_info_list->value =3D cmd_info; > cmd_info_list->next =3D info->supported_commands; > diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json > index 7155b7a..245f968 100644 > --- a/qga/qapi-schema.json > +++ b/qga/qapi-schema.json > @@ -141,10 +141,13 @@ > # > # @enabled: whether command is currently enabled by guest admin > # > +# @success-response: whether command returns a response on success > +# (since 1.7) > +# > # Since 1.1.0 > ## > { 'type': 'GuestAgentCommandInfo', > - 'data': { 'name': 'str', 'enabled': 'bool' } } > + 'data': { 'name': 'str', 'enabled': 'bool', 'success-response': 'bool'= } } > = > ## > # @GuestAgentInfo > -- = > 1.8.3.1