* [Qemu-devel] [PATCH] qcow2: CHECK_OFLAG_COPIED is obsolete
@ 2013-09-30 7:21 Max Reitz
2013-09-30 8:07 ` Kevin Wolf
2013-10-02 9:40 ` Stefan Hajnoczi
0 siblings, 2 replies; 3+ messages in thread
From: Max Reitz @ 2013-09-30 7:21 UTC (permalink / raw)
To: qemu-devel; +Cc: Kevin Wolf, Stefan Hajnoczi, Max Reitz
CHECK_OFLAG_COPIED as a parameter to check_refcounts_l1 and
check_refcounts_l2 is obselete now, since the OFLAG_COPIED consistency
check is actually no longer performed by these functions (but by
check_oflag_copied).
Signed-off-by: Max Reitz <mreitz@redhat.com>
---
block/qcow2-refcount.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c
index d2b7064..c0b4184 100644
--- a/block/qcow2-refcount.c
+++ b/block/qcow2-refcount.c
@@ -1034,7 +1034,6 @@ static void inc_refcounts(BlockDriverState *bs,
/* Flags for check_refcounts_l1() and check_refcounts_l2() */
enum {
- CHECK_OFLAG_COPIED = 0x1, /* check QCOW_OFLAG_COPIED matches refcount */
CHECK_FRAG_INFO = 0x2, /* update BlockFragInfo counters */
};
@@ -1481,8 +1480,7 @@ int qcow2_check_refcounts(BlockDriverState *bs, BdrvCheckResult *res,
/* current L1 table */
ret = check_refcounts_l1(bs, res, refcount_table, nb_clusters,
- s->l1_table_offset, s->l1_size,
- CHECK_OFLAG_COPIED | CHECK_FRAG_INFO);
+ s->l1_table_offset, s->l1_size, CHECK_FRAG_INFO);
if (ret < 0) {
goto fail;
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] qcow2: CHECK_OFLAG_COPIED is obsolete
2013-09-30 7:21 [Qemu-devel] [PATCH] qcow2: CHECK_OFLAG_COPIED is obsolete Max Reitz
@ 2013-09-30 8:07 ` Kevin Wolf
2013-10-02 9:40 ` Stefan Hajnoczi
1 sibling, 0 replies; 3+ messages in thread
From: Kevin Wolf @ 2013-09-30 8:07 UTC (permalink / raw)
To: Max Reitz; +Cc: qemu-devel, Stefan Hajnoczi
Am 30.09.2013 um 09:21 hat Max Reitz geschrieben:
> CHECK_OFLAG_COPIED as a parameter to check_refcounts_l1 and
> check_refcounts_l2 is obselete now, since the OFLAG_COPIED consistency
> check is actually no longer performed by these functions (but by
> check_oflag_copied).
>
> Signed-off-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] qcow2: CHECK_OFLAG_COPIED is obsolete
2013-09-30 7:21 [Qemu-devel] [PATCH] qcow2: CHECK_OFLAG_COPIED is obsolete Max Reitz
2013-09-30 8:07 ` Kevin Wolf
@ 2013-10-02 9:40 ` Stefan Hajnoczi
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Hajnoczi @ 2013-10-02 9:40 UTC (permalink / raw)
To: Max Reitz; +Cc: Kevin Wolf, qemu-devel
On Mon, Sep 30, 2013 at 09:21:07AM +0200, Max Reitz wrote:
> CHECK_OFLAG_COPIED as a parameter to check_refcounts_l1 and
> check_refcounts_l2 is obselete now, since the OFLAG_COPIED consistency
> check is actually no longer performed by these functions (but by
> check_oflag_copied).
>
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
> block/qcow2-refcount.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-10-02 9:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-30 7:21 [Qemu-devel] [PATCH] qcow2: CHECK_OFLAG_COPIED is obsolete Max Reitz
2013-09-30 8:07 ` Kevin Wolf
2013-10-02 9:40 ` Stefan Hajnoczi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).