From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34241)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1VQfi3-00080Z-Ds
	for qemu-devel@nongnu.org; Mon, 30 Sep 2013 11:48:37 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1VQfhx-0004P1-2x
	for qemu-devel@nongnu.org; Mon, 30 Sep 2013 11:48:31 -0400
Received: from mx1.redhat.com ([209.132.183.28]:64877)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1VQfhw-0004Ol-S1
	for qemu-devel@nongnu.org; Mon, 30 Sep 2013 11:48:25 -0400
Date: Mon, 30 Sep 2013 18:50:44 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20130930155044.GA10306@redhat.com>
References: <1380452123-5989-1-git-send-email-mst@redhat.com>
	<1380452123-5989-2-git-send-email-mst@redhat.com>
	<20130930151056.32699e7f@nial.usersys.redhat.com>
	<20130930144050.GB22806@redhat.com>
	<CAFEAcA8Q3EWwL=fKgaYP-eYXR5aVJ1iMkTT71D=nEPmm+0OOiQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAFEAcA8Q3EWwL=fKgaYP-eYXR5aVJ1iMkTT71D=nEPmm+0OOiQ@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH v6 01/26] qemu: add Error to typedefs
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>, Igor Mammedov <imammedo@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>, Andreas =?iso-8859-1?Q?F=E4rber?= <afaerber@suse.de>, Paolo Bonzini <pbonzini@redhat.com>

On Tue, Oct 01, 2013 at 12:10:52AM +0900, Peter Maydell wrote:
> On 30 September 2013 23:40, Michael S. Tsirkin <mst@redhat.com> wrote:
> > diff --git a/include/qapi/error.h b/include/qapi/error.h
> > index 7d4c696..b85e996 100644
> > --- a/include/qapi/error.h
> > +++ b/include/qapi/error.h
> > @@ -13,14 +13,15 @@
> >  #define ERROR_H
> >
> >  #include "qemu/compiler.h"
> > +#include "qemu/typedefs.h"
> >  #include "qapi-types.h"
> >  #include <stdbool.h>
> >
> >  /**
> > - * A class representing internal errors within QEMU.  An error has a ErrorClass
> > + * Error:
> > + * An object representing internal errors within QEMU.  An error has a ErrorClass
> >   * code and a human message.
> >   */
> > -typedef struct Error Error;
> 
> Does the process-doc-comments tool really cope with documentation comments
> that are completely separate from the typedef like this?
> 
> thanks
> -- PMM

Do we care?
Downstreams don't seem to package it, most people probably use
editor tags anyway ...
If yes we can put this all in #if 0.