From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36239)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1VQfpq-0003iC-9E
	for qemu-devel@nongnu.org; Mon, 30 Sep 2013 11:56:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1VQfpk-0007CD-As
	for qemu-devel@nongnu.org; Mon, 30 Sep 2013 11:56:34 -0400
Received: from mx1.redhat.com ([209.132.183.28]:53950)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1VQfpk-0007BD-33
	for qemu-devel@nongnu.org; Mon, 30 Sep 2013 11:56:28 -0400
Date: Mon, 30 Sep 2013 18:58:44 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20130930155844.GB10306@redhat.com>
References: <1378956318-23395-1-git-send-email-pingfank@linux.vnet.ibm.com>
	<1378956318-23395-3-git-send-email-pingfank@linux.vnet.ibm.com>
	<20130928195635.GC1051@redhat.com>
	<CAJnKYQmMDmkOM=c7rGxaqNBNSLtF46P+9DWV7bAoiUKXz84CqA@mail.gmail.com>
	<20130929041547.GA28242@redhat.com>
	<CAJnKYQn1s2WN3AfOr1Uv35Wf_ip6-e5_LUVwWOK-Lz1J4PN4yw@mail.gmail.com>
	<20130930090631.GC20291@redhat.com> <52493F28.5090303@redhat.com>
	<20130930093000.GE20291@redhat.com> <52499D33.9020603@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <52499D33.9020603@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v5 2/5] hpet: entitle more irq pins for hpet
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, Anthony Liguori <anthony@codemonkey.ws>, Jan Kiszka <jan.kiszka@siemens.com>, liu ping fan <qemulist@gmail.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>, Andreas =?iso-8859-1?Q?F=E4rber?= <afaerber@suse.de>

On Mon, Sep 30, 2013 at 05:48:03PM +0200, Paolo Bonzini wrote:
> Il 30/09/2013 11:30, Michael S. Tsirkin ha scritto:
> > I was really only talking about q35 here.
> > I thought it's ugly that users can control intcap
> > directly. Can object_set_property be used after
> > qdev_try_create?
> 
> Yes, after that and before qdev_init.  This is how Ping Fan is doing
> PIIX right now.
> 
> > PIIX has another issue:
> > the default value in hpet is really Q35 specific,
> > that's also kind of ugly, isn't it?
> 
> Yeah, perhaps it is.  So are you suggesting the default to be 4 (GSI2 only)?
> 
> Paolo

I suggest it fails unless caller set the property.